Thread decls-list through Declaration

src/asmjs/asm-typer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/asmjs/asm-typer.h"
 
 #include <algorithm>
 #include <limits>
 #include <memory>
 #include <string>
@@ skipping 629 matching lines @@
         FAIL(fun, "Multiple export statements.");
       }
       module_return = current_as_return;
       source_layout.AddExport(*module_return);
       continue;
     }
 
     FAIL(current, "Invalid top-level statement in asm.js module.");
   }
 
-  ZoneList<Declaration*>* decls = scope->declarations();
-
-  for (int ii = 0; ii < decls->length(); ++ii) {
-    Declaration* decl = decls->at(ii);
-
+  Declaration::List* decls = scope->declarations();
+  for (Declaration* decl : *decls) {
     if (FunctionDeclaration* fun_decl = decl->AsFunctionDeclaration()) {
       RECURSE(ValidateFunction(fun_decl));
       source_layout.AddFunction(*fun_decl);
       continue;
     }
   }
 
   for (auto* function_table : function_pointer_tables) {
     RECURSE(ValidateFunctionTable(function_table));
     source_layout.AddTable(*function_table);
   }
 
-  for (int ii = 0; ii < decls->length(); ++ii) {
-    Declaration* decl = decls->at(ii);
-
+  for (Declaration* decl : *decls) {
     if (decl->IsFunctionDeclaration()) {
       continue;
     }
 
     VariableDeclaration* var_decl = decl->AsVariableDeclaration();
     if (var_decl == nullptr) {
       FAIL(decl, "Invalid asm.js declaration.");
     }
 
     auto* var_proxy = var_decl->proxy();
@@ skipping 474 matching lines @@
         // We don't check whether AsReturnStatement() below returns non-null --
         // we leave that to the ReturnTypeAnnotations method.
         RECURSE(return_type_ =
                     ReturnTypeAnnotations(last_statement->AsReturnStatement()));
       }
     }
   } while (return_type_ == AsmType::None());
 
   DCHECK(return_type_->IsReturnType());
 
-  for (auto* decl : *fun->scope()->declarations()) {
+  for (Declaration* decl : *fun->scope()->declarations()) {
     auto* var_decl = decl->AsVariableDeclaration();
     if (var_decl == nullptr) {
       FAIL(decl, "Functions may only define inner variables.");
     }
 
     auto* var_proxy = var_decl->proxy();
     if (var_proxy == nullptr) {
       FAIL(decl, "Invalid local declaration declaration.");
     }
 
@@ skipping 1683 matching lines @@
     return true;
   }
 
   *error_message = typer.error_message();
   return false;
 }
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8