Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2457353002: aw: Enable async ondraw (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Enable async ondraw And reverse async ondraw switch, ie convert it to a switch to disable instead so that it can be easily turned off. BUG=636164 Committed: https://crrev.com/2d057e4907ab0df750c5d3bc208881151be2ac81 Cr-Commit-Position: refs/heads/master@{#431072}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M android_webview/browser/browser_view_renderer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/render_thread_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/render_thread_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/test/rendering_test.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M android_webview/common/aw_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
boliu
second time is the charm?
4 years, 1 month ago (2016-11-09 17:35:58 UTC) #3
boliu
+sgurun to stamp in mtv time? This also reverses the flag, since I don't think ...
4 years, 1 month ago (2016-11-09 20:39:20 UTC) #5
sgurun-gerrit only
On 2016/11/09 20:39:20, boliu wrote: > +sgurun to stamp in mtv time? > > This ...
4 years, 1 month ago (2016-11-09 21:41:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457353002/20001
4 years, 1 month ago (2016-11-09 21:44:39 UTC) #8
boliu
oh, unit test broken :/
4 years, 1 month ago (2016-11-09 22:23:30 UTC) #9
boliu
unit tests still run in synchronous ondraw mode for now..
4 years, 1 month ago (2016-11-09 22:43:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457353002/40001
4 years, 1 month ago (2016-11-09 22:44:20 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-09 23:13:52 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 23:16:00 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2d057e4907ab0df750c5d3bc208881151be2ac81
Cr-Commit-Position: refs/heads/master@{#431072}

Powered by Google App Engine
This is Rietveld 408576698