Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: PRESUBMIT.py

Issue 2457343002: Remove stl_util's STLDeleteContainerPointers. (Closed)
Patch Set: for Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/containers/scoped_ptr_hash_map.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 ), 310 ),
311 ( 311 (
312 '#pragma comment(lib,', 312 '#pragma comment(lib,',
313 ( 313 (
314 'Specify libraries to link with in build files and not in the source.', 314 'Specify libraries to link with in build files and not in the source.',
315 ), 315 ),
316 True, 316 True,
317 (), 317 (),
318 ), 318 ),
319 ( 319 (
320 r'STLDeleteContainerPointers', # http://crbug.com/555865
321 (
322 'This call is obsolete with C++ 11; create a container with owning',
323 'pointers instead (e.g. std::vector<std::unique_ptr<x>> ).',
324 ),
325 True,
326 (),
327 ),
328 (
329 r'STLDeleteElements', # http://crbug.com/555865 320 r'STLDeleteElements', # http://crbug.com/555865
330 ( 321 (
331 'This call is obsolete with C++ 11; create a container with owning', 322 'This call is obsolete with C++ 11; create a container with owning',
332 'pointers instead (e.g. std::vector<std::unique_ptr<x>> ).', 323 'pointers instead (e.g. std::vector<std::unique_ptr<x>> ).',
333 ), 324 ),
334 True, 325 True,
335 (), 326 (),
336 ), 327 ),
337 ( 328 (
338 r'STLDeleteValues', # http://crbug.com/555865 329 r'STLDeleteValues', # http://crbug.com/555865
(...skipping 1961 matching lines...) Expand 10 before | Expand all | Expand 10 after
2300 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2291 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2301 input_api, 2292 input_api,
2302 output_api, 2293 output_api,
2303 json_url='http://chromium-status.appspot.com/current?format=json')) 2294 json_url='http://chromium-status.appspot.com/current?format=json'))
2304 2295
2305 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2296 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2306 input_api, output_api)) 2297 input_api, output_api))
2307 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2298 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2308 input_api, output_api)) 2299 input_api, output_api))
2309 return results 2300 return results
OLDNEW
« no previous file with comments | « no previous file | base/containers/scoped_ptr_hash_map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698