Remove stl_util's STLDeleteContainerPointers.

Remove stl_util's STLDeleteContainerPointers.

BUG=555865
Committed: https://crrev.com/72d3b88b5e27a7ad7cd2baf421e8432d15a510a3
Cr-Commit-Position: refs/heads/master@{#429152}

[Avi (use Gerrit), 2016-10-29 23:03:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-29 23:03:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 00:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 00:48:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2016-10-30 18:20:08]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 18:20:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-30 19:52:59]

avi@chromium.org changed reviewers:
+ jam@chromium.org

[Avi (use Gerrit), 2016-10-30 19:53:00]

PTAL

[commit-bot: I haz the power, 2016-10-30 19:58:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 19:58:23]

Dry run: This issue passed the CQ dry run.

[jam, 2016-10-31 16:54:04]

presubmit lgtm, please add base/ owner for rest

[Avi (use Gerrit), 2016-10-31 18:22:44]

avi@chromium.org changed reviewers:
+ mark@chromium.org

[Avi (use Gerrit), 2016-10-31 18:22:45]

Mark, ptal.

[Mark Mentovai, 2016-10-31 19:52:02]

LGTM

https://codereview.chromium.org/2457343002/diff/1/base/stl_util.h
File base/stl_util.h (right):

https://codereview.chromium.org/2457343002/diff/1/base/stl_util.h#newcode72
base/stl_util.h:72: while (it != container->end()) {
for would be more concise by one line.

[Avi (use Gerrit), 2016-10-31 21:17:27]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-10-31 21:17:40]

https://codereview.chromium.org/2457343002/diff/1/base/stl_util.h
File base/stl_util.h (right):

https://codereview.chromium.org/2457343002/diff/1/base/stl_util.h#newcode72
base/stl_util.h:72: while (it != container->end()) {
On 2016/10/31 19:52:02, Mark Mentovai wrote:
> for would be more concise by one line.

Is the issue of not being able to advance the iterator noted in the comment on
STLDeleteContainerPointers not an issue? I kept the same basic structure because
I wasn't entirely sure and because I'm getting rid of this soon, also.

[commit-bot: I haz the power, 2016-10-31 21:17:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-10-31 21:20:17]

I meant to have a blank third clause of the for. You’ll only save one line, not
two. LGTM either way.

[Avi (use Gerrit), 2016-10-31 21:25:01]

On 2016/10/31 21:17:40, Avi wrote:
> https://codereview.chromium.org/2457343002/diff/1/base/stl_util.h
> File base/stl_util.h (right):
> 
> https://codereview.chromium.org/2457343002/diff/1/base/stl_util.h#newcode72
> base/stl_util.h:72: while (it != container->end()) {
> On 2016/10/31 19:52:02, Mark Mentovai wrote:
> > for would be more concise by one line.
> 
> Is the issue of not being able to advance the iterator noted in the comment on
> STLDeleteContainerPointers not an issue? I kept the same basic structure
because
> I wasn't entirely sure and because I'm getting rid of this soon, also.

Ah, yes, that would be cleaner. Done.

[Avi (use Gerrit), 2016-11-01 15:22:52]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-11-01 15:22:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2457343002/#ps40001
(title: "for")

[commit-bot: I haz the power, 2016-11-01 15:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 17:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 17:50:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2016-11-01 19:49:53]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-11-01 19:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 23:30:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 23:33:09]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPointers.

BUG=555865
==========

to

==========
Remove stl_util's STLDeleteContainerPointers.

BUG=555865

Committed: https://crrev.com/72d3b88b5e27a7ad7cd2baf421e8432d15a510a3
Cr-Commit-Position: refs/heads/master@{#429152}
==========

[commit-bot: I haz the power, 2016-11-01 23:33:10]

Patchset 3 (id:??) landed as
https://crrev.com/72d3b88b5e27a7ad7cd2baf421e8432d15a510a3
Cr-Commit-Position: refs/heads/master@{#429152}