Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Unified Diff: tests/gdb/nacl.scons

Issue 245733002: Added arguments to NaCl scons to allow custom toolchain directories. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Use abspath of environment instead of cwd since cwd can change per test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site_scons/site_tools/naclsdk.py ('k') | tools/Makefile » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gdb/nacl.scons
diff --git a/tests/gdb/nacl.scons b/tests/gdb/nacl.scons
index 78120a0f930dcef1f161e061b888906f519464c2..790598ca6b9fe157df11d1f0fdbc7d14a982e7f1 100644
--- a/tests/gdb/nacl.scons
+++ b/tests/gdb/nacl.scons
@@ -18,15 +18,9 @@ if env.Bit('target_arm') or env.Bit('target_mips32'):
# nacl-gdb is built with ARM support but not MIPS support.
if env.Bit('target_mips32'):
Return()
- platform_build_dir = env.GetPlatformBuildTargetDir()
- toolchain_name = env.GetToolchainName(target_arch='x86',
- is_pnacl=False,
- lib_name='newlib')
-
- nacl_x86_toolchain_dir = env.GetToolchainDir(
- platform_build_dir=platform_build_dir,
- toolchain_name=toolchain_name
- )
+ nacl_x86_toolchain_dir = env.GetToolchainDir(target_arch='x86',
+ is_pnacl=False,
+ lib_name='newlib')
nacl_gdb_path = os.path.join(nacl_x86_toolchain_dir, 'bin', 'i686-nacl-gdb')
env.Replace(GDB=nacl_gdb_path)
else:
« no previous file with comments | « site_scons/site_tools/naclsdk.py ('k') | tools/Makefile » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698