Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 24573002: Layout Test editing/spelling/spelling-huge-text.html is flaky (Closed)

Created:
7 years, 2 months ago by grzegorz
Modified:
7 years, 2 months ago
Reviewers:
tony, gmorrita
CC:
blink-reviews, groby+blinkspell_chromium.org, loislo
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Layout Test editing/spelling/spelling-huge-text.html is flaky Such huge text needs more time to be spell checked. shouldBecomeEqual that was used to check spelling asynchronously allows to pass timeout value. Change its the default value (500 ms) in this test to 1000 ms. BUG=298047 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-huge-text.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
grzegorz
On my machine with debug build, this huge text needs ~400 ms to be spell ...
7 years, 2 months ago (2013-09-25 12:33:05 UTC) #1
tony
LGTM
7 years, 2 months ago (2013-09-25 16:41:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/24573002/1
7 years, 2 months ago (2013-09-25 16:42:17 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-25 21:52:57 UTC) #4
Message was sent while issue was closed.
Change committed as 158339

Powered by Google App Engine
This is Rietveld 408576698