Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2457173002: Main waterfall blink testers should not compile locally. (Closed)

Created:
4 years, 1 month ago by erikchen
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Main waterfall blink testers should not compile locally. There are already dedicated builders for compilation. BUG=659270 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5ffef937190e0b93938defbde7c4d6325fa8c10a

Patch Set 1 #

Patch Set 2 : Train. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -240 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11__retina_.json View 1 7 chunks +143 lines, -143 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_9.json View 1 6 chunks +189 lines, -92 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder.json View 1 2 chunks +59 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
erikchen
dpranke: Please review.
4 years, 1 month ago (2016-10-28 20:16:55 UTC) #2
Dirk Pranke
On 2016/10/28 20:16:55, erikchen wrote: > dpranke: Please review. lgtm. The Retina builder might actually ...
4 years, 1 month ago (2016-10-28 20:22:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457173002/20001
4 years, 1 month ago (2016-10-28 20:24:53 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 20:34:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/5ffef937190e0b93938d...

Powered by Google App Engine
This is Rietveld 408576698