Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6874)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2457153002: replacing the NullCulprit class by None (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/culprit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 51491761aa73dd5592b143541aa93c41acfbfe39..9532858384a378b823d50d401baf93fd03345739 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -120,7 +120,18 @@ class CrashAnalysisPipeline(CrashBasePipeline):
analysis.put()
# Actually do the analysis.
- result, tags = self._findit.FindCulprit(analysis).ToDicts()
+ culprit = self._findit.FindCulprit(analysis)
+ if culprit is not None:
+ result, tags = culprit.ToDicts()
+ else:
+ result = {'found': False}
+ tags = {
+ 'found_suspects': False,
+ 'found_project': False,
+ 'found_components': False,
+ 'has_regression_range': False,
+ 'solution': None,
+ }
# Update model's status to say we're done, and save the results.
analysis.completed_time = time_util.GetUTCNow()
« no previous file with comments | « no previous file | appengine/findit/crash/culprit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698