replacing the NullCulprit class by None

appengine/findit/crash/findit.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from common import chrome_dependency_fetcher
 from common import constants
 from common import time_util
 from crash.crash_report import CrashReport
-from crash.culprit import NullCulprit
 from model import analysis_status
 from model.crash.crash_config import CrashConfig
 
 # TODO(http://crbug.com/659346): since most of our unit tests are
 # FinditForFracas-specific, wrengr moved them to findit_for_chromecrash_test.py.
 # However, now we're missing coverage for most of this file (due to the
 # buggy way coverage is computed). Need to add a bunch of new unittests
 # to get coverage back up.
 
 # TODO: this class depends on ndb stuff, and should therefore move to
@@ skipping 244 matching lines @@
   # TODO(wrengr): This is only called by |CrashAnalysisPipeline.run|;
   # we should be able to adjust things so that we only need to take in
   # |crash_identifiers|, or a CrashReport, rather than taking in the
   # whole model. And/or, we should just inline this there.
   # TODO(http://crbug.com/659346): coverage tests for this class, not
   # just for FinditForFracas.
   def FindCulprit(self, model): # pragma: no cover
     """Given a CrashAnalysis ndb.Model, return a Culprit."""
     stacktrace = self.ParseStacktrace(model)
     if stacktrace is None:
-      # TODO(http://crbug.com/659359): refactor things so we don't need
-      # the NullCulprit class.
-      return NullCulprit()
+      return None

[Sharu Jiang, 2016/10/28 20:34:12]

It's ok to return None here, but you need to update the related part in
CrashAnalysisPipeline in the crash_pipeline.py.

And in this case, you still need to push
{'found': False} to clients and update CrashAnalysis model in data store using 
{'found_suspects': False,
 'found_project': False,
 'found_components': False,
 'has_regression_range': False,
 'solution': None}

[wrengr, 2016/10/28 21:11:19]

Indeed, the goal of this CL is to allow returning None here. Shouldn't the
'solution' be the algorithm that was tried and failed to find a culprit, as you
said in the other CL?

[Sharu Jiang, 2016/10/28 23:40:58]

Yes, the algorithm is a better name, however when you update the CrashAnalysis
model, it should be 'solution', we can change that field name, however there
would be a legacy problem... though it won't have much impact right now.

 
     return self._azalea.FindCulprit(CrashReport(
         crashed_version = model.crashed_version,
         signature = model.signature,
         platform = model.platform,
         stacktrace = stacktrace,
         regression_range = model.regression_range))