Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 2457143002: mash: Keep Chrome alive with ChromeSessionManager (Closed)

Created:
4 years, 1 month ago by xiyuan
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Keep Chrome alive with ChromeSessionManager BUG=660450 Committed: https://crrev.com/4ca5810d6c230db6ba2ca22ffd0671e4cac25aea Cr-Commit-Position: refs/heads/master@{#428462}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/chromeos/login/session/chrome_session_manager.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xiyuan
The CL keeps Chrome running with ChromeSessionManager for mash. Think we need something like this ...
4 years, 1 month ago (2016-10-28 18:32:11 UTC) #6
sky
LGTM
4 years, 1 month ago (2016-10-28 19:32:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457143002/20001
4 years, 1 month ago (2016-10-28 19:35:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 19:41:37 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:56:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ca5810d6c230db6ba2ca22ffd0671e4cac25aea
Cr-Commit-Position: refs/heads/master@{#428462}

Powered by Google App Engine
This is Rietveld 408576698