[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide InstructionVector us…

[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide InstructionVector usage.

To reduce Courgette memory usage (and possibly solve installer crashes),
we plan to make AssemblyProgram store instructions more efficiently. We
start by hiding AssemblyProgram's InstructionVector usage from
AdjustmentMethod and AdjustmentMethod2.

Previously AdjustmentMethod[2] get AssemblyProgram's instruction vector,
and loop over it to extract labels from abs32/rel32 instructions. This
CL moves the loop into AssemblyProgram::DispatchInstructionLabels().
Callers now specify a map of handlers, without needing to know how
instructions are stored in AssemblyProgram.

Committed: https://crrev.com/99a5a8c3c7923a01d37a6d6d63203234d310e320
Cr-Commit-Position: refs/heads/master@{#428522}

[huangs, 2016-10-28 18:49:13]

Description was changed from

==========
[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide
InstructionVector usage.

To reduce Courgette memory usage (and possibly solve installer crashes),
we plan to make AssemblyProgram store instructions more efficiently. We
start by hiding InstructionVector usage by AssemblyProgram, by plugging
abstraction leakages by AdjustmentMethod and AdjustmentMethod2.

Previously AdjustmentMethod[2] gets AssemblyProgram's instruction vector
to store labels from abs32/rel32 instructions. In this CL, we move the
iteration into AssemblyProgram::DispatchInstructionLabels(). The callers
now specify a map of handlers, without needing to know how instructions
are stored inside AssemblyProgram.
==========

to

==========
[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide
InstructionVector usage.

To reduce Courgette memory usage (and possibly solve installer crashes),
we plan to make AssemblyProgram store instructions more efficiently. We
start by hiding AssemblyProgram's InstructionVector usage from
AdjustmentMethod and AdjustmentMethod2.

Previously AdjustmentMethod[2] get AssemblyProgram's instruction vector,
and loop over it to extract labels from abs32/rel32 instructions. This
CL moves the loop into AssemblyProgram::DispatchInstructionLabels().
Callers now specify a map of handlers, without needing to know how
instructions are stored in AssemblyProgram.
==========

[huangs, 2016-10-28 18:49:13]

huangs@chromium.org changed reviewers:
+ chrisha@chromium.org

[huangs, 2016-10-28 18:49:25]

PTAL. Thanks!

[chrisha, 2016-10-28 20:39:14]

I find the "hander" and "dispatch" terminology slightly inconsistent, but
overall lgtm.

https://codereview.chromium.org/2457133002/diff/1/courgette/assembly_program.h
File courgette/assembly_program.h (right):

https://codereview.chromium.org/2457133002/diff/1/courgette/assembly_program....
courgette/assembly_program.h:84: using LabelDispatcherMap = std::map<OP,
LabelHandler>;
LabelHandlerMap, for consistency?

https://codereview.chromium.org/2457133002/diff/1/courgette/assembly_program....
courgette/assembly_program.h:153: void DispatchInstructionLabels(const
LabelDispatcherMap& dispatcher) const;
HandleInstructionLabels?

Are we "dispatching" anything? Are messages being routed?

[huangs, 2016-10-28 21:48:13]

Thanks. Committing!

https://codereview.chromium.org/2457133002/diff/1/courgette/assembly_program.h
File courgette/assembly_program.h (right):

https://codereview.chromium.org/2457133002/diff/1/courgette/assembly_program....
courgette/assembly_program.h:84: using LabelDispatcherMap = std::map<OP,
LabelHandler>;
On 2016/10/28 20:39:14, chrisha (slow) wrote:
> LabelHandlerMap, for consistency?

Done.

https://codereview.chromium.org/2457133002/diff/1/courgette/assembly_program....
courgette/assembly_program.h:153: void DispatchInstructionLabels(const
LabelDispatcherMap& dispatcher) const;
On 2016/10/28 20:39:14, chrisha (slow) wrote:
> HandleInstructionLabels?
> 
> Are we "dispatching" anything? Are messages being routed?

Done.

[huangs, 2016-10-28 21:48:18]

The CQ bit was checked by huangs@chromium.org

[huangs, 2016-10-28 21:48:18]

The patchset sent to the CQ was uploaded after l-g-t-m from chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2457133002/#ps20001
(title: "Rename 'Dispatch' to 'Handle'.")

[commit-bot: I haz the power, 2016-10-28 21:49:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:29:56]

Description was changed from

==========
[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide
InstructionVector usage.

To reduce Courgette memory usage (and possibly solve installer crashes),
we plan to make AssemblyProgram store instructions more efficiently. We
start by hiding AssemblyProgram's InstructionVector usage from
AdjustmentMethod and AdjustmentMethod2.

Previously AdjustmentMethod[2] get AssemblyProgram's instruction vector,
and loop over it to extract labels from abs32/rel32 instructions. This
CL moves the loop into AssemblyProgram::DispatchInstructionLabels().
Callers now specify a map of handlers, without needing to know how
instructions are stored in AssemblyProgram.
==========

to

==========
[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide
InstructionVector usage.

To reduce Courgette memory usage (and possibly solve installer crashes),
we plan to make AssemblyProgram store instructions more efficiently. We
start by hiding AssemblyProgram's InstructionVector usage from
AdjustmentMethod and AdjustmentMethod2.

Previously AdjustmentMethod[2] get AssemblyProgram's instruction vector,
and loop over it to extract labels from abs32/rel32 instructions. This
CL moves the loop into AssemblyProgram::DispatchInstructionLabels().
Callers now specify a map of handlers, without needing to know how
instructions are stored in AssemblyProgram.
==========

[commit-bot: I haz the power, 2016-10-28 22:29:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 22:31:40]

Description was changed from

==========
[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide
InstructionVector usage.

To reduce Courgette memory usage (and possibly solve installer crashes),
we plan to make AssemblyProgram store instructions more efficiently. We
start by hiding AssemblyProgram's InstructionVector usage from
AdjustmentMethod and AdjustmentMethod2.

Previously AdjustmentMethod[2] get AssemblyProgram's instruction vector,
and loop over it to extract labels from abs32/rel32 instructions. This
CL moves the loop into AssemblyProgram::DispatchInstructionLabels().
Callers now specify a map of handlers, without needing to know how
instructions are stored in AssemblyProgram.
==========

to

==========
[Courgette] Refactor: Add AssemblyProgram::DispatchInstructionLabels() to hide
InstructionVector usage.

To reduce Courgette memory usage (and possibly solve installer crashes),
we plan to make AssemblyProgram store instructions more efficiently. We
start by hiding AssemblyProgram's InstructionVector usage from
AdjustmentMethod and AdjustmentMethod2.

Previously AdjustmentMethod[2] get AssemblyProgram's instruction vector,
and loop over it to extract labels from abs32/rel32 instructions. This
CL moves the loop into AssemblyProgram::DispatchInstructionLabels().
Callers now specify a map of handlers, without needing to know how
instructions are stored in AssemblyProgram.

Committed: https://crrev.com/99a5a8c3c7923a01d37a6d6d63203234d310e320
Cr-Commit-Position: refs/heads/master@{#428522}
==========

[commit-bot: I haz the power, 2016-10-28 22:31:41]

Patchset 2 (id:??) landed as
https://crrev.com/99a5a8c3c7923a01d37a6d6d63203234d310e320
Cr-Commit-Position: refs/heads/master@{#428522}

[huangs, 2016-10-31 22:43:00]

Oops the title and description should use "Handle", not "Dispatch".

Also, tracking bug is: http://crbug.com/660980