Issue 24571002: FieldTrial: Remove friend declarations for non-existing tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24571002: FieldTrial: Remove friend declarations for non-existing tests (Closed)

Created:
7 years, 2 months ago by vabr (Chromium)

Modified:
7 years, 2 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

FieldTrial: Remove friend declarations for non-existing tests The tests were removed in https://codereview.chromium.org/10151017 and https://codereview.chromium.org/10830318 but are still referenced as friends. BUG=143239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225445

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	base/metrics/field_trial.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

vabr (Chromium)

Hi, Could you please review this little clean-up? I checked that the other friend-declared tests ...

7 years, 2 months ago (2013-09-25 12:22:46 UTC) #1

jar (doing other things)

lgtm Assuming this gets past the trybots....

7 years, 2 months ago (2013-09-25 20:07:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/24571002/1

7 years, 2 months ago (2013-09-25 20:07:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/24571002/1

7 years, 2 months ago (2013-09-25 21:57:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/24571002/1

7 years, 2 months ago (2013-09-26 08:24:35 UTC) #5

Message was sent while issue was closed.

Change committed as 225445