Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2457093002: [ios] Adds VoiceSearchProvider::IsVoiceSearchEnabled(). (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto, lpromero
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds VoiceSearchProvider::IsVoiceSearchEnabled(). The other provider methods must not be called if voice search is disabled. BUG=656617 Committed: https://crrev.com/d2b3e48271c11701aae1fdb32188b3390664fa35 Cr-Commit-Position: refs/heads/master@{#428393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/voice/voice_search_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-10-28 15:06:45 UTC) #2
lpromero
lgtm
4 years, 1 month ago (2016-10-28 16:31:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457093002/1
4 years, 1 month ago (2016-10-28 16:32:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 16:54:47 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:21:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2b3e48271c11701aae1fdb32188b3390664fa35
Cr-Commit-Position: refs/heads/master@{#428393}

Powered by Google App Engine
This is Rietveld 408576698