Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2457063002: aw: Enable async ondraw by default (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org, Tobias Sargeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Enable async ondraw by default First attempt at enabling. Hopefully it sticks. BUG=636164 Committed: https://crrev.com/28281dff0b3e8fd9702bfffa8e90e8212e53f16f Cr-Commit-Position: refs/heads/master@{#428460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
boliu
pulling da trigger
4 years, 1 month ago (2016-10-28 04:42:35 UTC) #2
sgurun-gerrit only
lgtm
4 years, 1 month ago (2016-10-28 19:22:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457063002/1
4 years, 1 month ago (2016-10-28 19:23:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 19:33:40 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28281dff0b3e8fd9702bfffa8e90e8212e53f16f Cr-Commit-Position: refs/heads/master@{#428460}
4 years, 1 month ago (2016-10-28 19:56:00 UTC) #12
boliu
4 years, 1 month ago (2016-11-02 17:57:10 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2467343002/ by boliu@chromium.org.

The reason for reverting is: Probable cause for memory regression (or leak?)

BUG=661504.

Powered by Google App Engine
This is Rietveld 408576698