components/resources/ntp_tiles_resources.grdp - Issue 2457033003: Add chrome://popular-sites-internals/ to iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resources/ntp_tiles_resources.grdp

Issue 2457033003: Add chrome://popular-sites-internals/ to iOS. (Closed)

Patch Set: Inline message handler impl. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_tiles/webui/popular_sites_handler.cc ('K') | « components/resources/components_resources.grd ('k') | ios/chrome/browser/chrome_url_constants.h » ('j') | ios/chrome/browser/chrome_url_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/resources/ntp_tiles_resources.grdp

diff --git a/components/resources/ntp_tiles_resources.grdp b/components/resources/ntp_tiles_resources.grdp

new file mode 100644

index 0000000000000000000000000000000000000000..384eacf5849f4b87f0aacc32ebac0c0d0d248c9e

--- /dev/null

+++ b/components/resources/ntp_tiles_resources.grdp

@@ -0,0 +1,6 @@

+<?xml version="1.0" encoding="utf-8"?>

+<grit-part>

+ <include name="IDR_POPULAR_SITES_INTERNALS_HTML" file="../ntp_tiles/webui/resources/popular_sites_internals.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />

sdefresne 2016/10/28 13:34:03 Can't you use <if expr="blah"> here?

sfiera 2016/10/28 13:38:14 I'll give it a try.

+ <include name="IDR_POPULAR_SITES_INTERNALS_JS" file="../ntp_tiles/webui/resources/popular_sites_internals.js" type="BINDATA" />

+ <include name="IDR_POPULAR_SITES_INTERNALS_CSS" file="../ntp_tiles/webui/resources/popular_sites_internals.css" type="BINDATA" />

+</grit-part>