Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2457023002: Replace coversExtraPixels with simpler logic (Closed)
Patch Set: - Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index 3633d7897d537c8bf082d8be9009af44cb58521b..1d23d73dcb5d8d4ddf3014c7091c50763e88ff1f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -1599,12 +1599,6 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
return m_previousPaintInvalidationRect;
}
- // The previous paint invalidation rect may have been expanded to whole pixels
- // or be rotated, skewed, etc., so covers more pixels than the object covers.
- bool previousPaintInvalidationRectCoversExtraPixels() const {
- return m_bitfields.previousPaintInvalidationRectCoversExtraPixels();
- }
-
// Called when the previous paint invalidation rect(s) is no longer valid.
virtual void clearPreviousPaintInvalidationRects();
@@ -1711,11 +1705,8 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
m_layoutObject.ensureIsReadyForPaintInvalidation();
}
- void setPreviousPaintInvalidationRect(const LayoutRect& r,
- bool coversExtraPixels) {
+ void setPreviousPaintInvalidationRect(const LayoutRect& r) {
m_layoutObject.setPreviousPaintInvalidationRect(r);
- m_layoutObject.m_bitfields
- .setPreviousPaintInvalidationRectCoversExtraPixels(coversExtraPixels);
}
void setPreviousPositionFromPaintInvalidationBacking(const LayoutPoint& p) {
m_layoutObject.setPreviousPositionFromPaintInvalidationBacking(p);
@@ -2102,7 +2093,6 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
m_mayNeedPaintInvalidationSubtree(false),
m_mayNeedPaintInvalidationAnimatedBackgroundImage(false),
m_shouldInvalidateSelection(false),
- m_previousPaintInvalidationRectCoversExtraPixels(false),
m_floating(false),
m_isAnonymous(!node),
m_isText(false),
@@ -2134,7 +2124,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
m_backgroundObscurationState(BackgroundObscurationStatusInvalid),
m_fullPaintInvalidationReason(PaintInvalidationNone) {}
- // 32 bits have been used in the first word, and 20 in the second.
+ // 32 bits have been used in the first word, and 19 in the second.
// Self needs layout means that this layout object is marked for a full
// layout. This is the default layout but it is expensive as it recomputes
@@ -2202,9 +2192,6 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
MayNeedPaintInvalidationAnimatedBackgroundImage);
ADD_BOOLEAN_BITFIELD(shouldInvalidateSelection, ShouldInvalidateSelection);
- ADD_BOOLEAN_BITFIELD(previousPaintInvalidationRectCoversExtraPixels,
- PreviousPaintInvalidationRectCoversExtraPixels);
-
// This boolean is the cached value of 'float'
// (see ComputedStyle::isFloating).
ADD_BOOLEAN_BITFIELD(floating, Floating);

Powered by Google App Engine
This is Rietveld 408576698