third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc - Issue 2457013004: Use NGLogicalRect instead of NGExclusion for exclusions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc

Issue 2457013004: Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)

Patch Set: renamed IsWithing to IsContained Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_fragment.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h ('k') | third_party/WebKit/Source/core/layout/ng/ng_units.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc

index 567ed676320a6625e8cac1805e738dbce33c5f8c..8a176bcb16ac11b91a4d4c3b7b7a0bcf195535ff 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc

@@ -24,12 +24,13 @@ NGPhysicalConstraintSpace::NGPhysicalConstraintSpace(

height_direction_fragmentation_type_(height_direction_fragmentation_type),

is_new_fc_(is_new_fc) {}

-void NGPhysicalConstraintSpace::AddExclusion(const NGExclusion* exclusion,

+void NGPhysicalConstraintSpace::AddExclusion(const NGLogicalRect& exclusion,

unsigned options) {

- exclusions_.append(exclusion);

+ NGLogicalRect* exclusion_ptr = new NGLogicalRect(exclusion);

+ exclusions_.append(WTF::wrapUnique(exclusion_ptr));

}

-const HeapVector<Member<const NGExclusion>>&

+const Vector<std::unique_ptr<const NGLogicalRect>>&

NGPhysicalConstraintSpace::Exclusions(unsigned options) const {

// TODO(layout-ng): Filter based on options? Perhaps layout Opportunities

// should filter instead?