third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc - Issue 2457013004: Use NGLogicalRect instead of NGExclusion for exclusions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2457013004: Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)

Patch Set: renamed IsWithing to IsContained Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

index 89915b93dd19587c520cb0a75d99501a60d83b05..950dc0d92e22968cbcf5d686a63ee6008165ad51 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

@@ -70,7 +70,9 @@ NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(

builder.ToConstraintSpace());

}

-void NGConstraintSpace::AddExclusion(const NGExclusion* exclusion) const {

+void NGConstraintSpace::AddExclusion(const NGLogicalRect& exclusion) const {

+ WRITING_MODE_IGNORED(

+ "Exclusions are stored directly in physical constraint space.");

MutablePhysicalSpace()->AddExclusion(exclusion);

}