Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2456993003: Improve caption button behavior for video player. (Closed)
Patch Set: Label string Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 16 matching lines...) Expand all
27 #ifndef MediaControls_h 27 #ifndef MediaControls_h
28 #define MediaControls_h 28 #define MediaControls_h
29 29
30 #include "core/html/HTMLDivElement.h" 30 #include "core/html/HTMLDivElement.h"
31 #include "core/html/shadow/MediaControlElements.h" 31 #include "core/html/shadow/MediaControlElements.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class Event; 35 class Event;
36 class TextTrackContainer; 36 class TextTrackContainer;
37 class TextTrackList;
37 class MediaControlsWindowEventListener; 38 class MediaControlsWindowEventListener;
38 39
39 class CORE_EXPORT MediaControls final : public HTMLDivElement { 40 class CORE_EXPORT MediaControls final : public HTMLDivElement {
40 public: 41 public:
41 static MediaControls* create(HTMLMediaElement&); 42 static MediaControls* create(HTMLMediaElement&);
42 43
43 HTMLMediaElement& mediaElement() const { return *m_mediaElement; } 44 HTMLMediaElement& mediaElement() const { return *m_mediaElement; }
44 45
45 void reset(); 46 void reset();
46 47
47 void show(); 48 void show();
48 void hide(); 49 void hide();
49 50
50 void playbackStarted(); 51 void playbackStarted();
51 void playbackProgressed(); 52 void playbackProgressed();
52 void playbackStopped(); 53 void playbackStopped();
53 54
54 void beginScrubbing(); 55 void beginScrubbing();
55 void endScrubbing(); 56 void endScrubbing();
56 57
57 void updateCurrentTimeDisplay(); 58 void updateCurrentTimeDisplay();
58 59
59 void updateVolume(); 60 void updateVolume();
60 61
61 void changedClosedCaptionsVisibility(); 62 void changedClosedCaptionsVisibility();
62 void refreshClosedCaptionsButtonVisibility(); 63 void refreshClosedCaptionsButtonVisibility();
63 void toggleTextTrackList(); 64 void toggleTextTrackList();
65 void showTextTrackAtIndex(TextTrackList*, unsigned indexToEnable);
66 void disableShowingTextTracks(TextTrackList*);
mlamouri (slow - plz ping) 2016/10/28 14:20:15 Instead of passing TextTrackList, could we get the
Finnur 2016/10/29 16:45:18 Yes, indeed. Much better. PTAL.
64 67
65 void enteredFullscreen(); 68 void enteredFullscreen();
66 void exitedFullscreen(); 69 void exitedFullscreen();
67 70
68 void startedCasting(); 71 void startedCasting();
69 void stoppedCasting(); 72 void stoppedCasting();
70 void refreshCastButtonVisibility(); 73 void refreshCastButtonVisibility();
71 void showOverlayCastButtonIfNeeded(); 74 void showOverlayCastButtonIfNeeded();
72 // Update cast button visibility, but don't try to update our panel 75 // Update cast button visibility, but don't try to update our panel
73 // button visibility for space. 76 // button visibility for space.
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 int m_panelWidth; 174 int m_panelWidth;
172 175
173 bool m_allowHiddenVolumeControls : 1; 176 bool m_allowHiddenVolumeControls : 1;
174 }; 177 };
175 178
176 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls()); 179 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());
177 180
178 } // namespace blink 181 } // namespace blink
179 182
180 #endif 183 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698