Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2456993002:
[Mac] Fix security chip page load issue (Closed)
|
Created:
4 years, 1 month ago by spqchan Modified:
4 years, 1 month ago Reviewers:
rohitrao (ping after 24h) CC:
chromium-reviews, mac-reviews_chromium.org, estark Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Fix security chip page load issue
Make sure that |is_width_available_for_security_verbose_| is always
updated when the omnibox is relayout.
BUG=657650
Committed: https://crrev.com/dedfa14969151652438f5a2795f5b4889714f20b
Cr-Commit-Position: refs/heads/master@{#428771}
Patch Set 1 #Patch Set 2 : nit #Messages
Total messages: 20 (13 generated)
Description was changed from ========== [Mac] Fix for page load security chips BUG= ========== to ========== [Mac] Fix security chip page load issue Make sure that |is_width_available_for_security_verbose_| is always updated when the omnibox is relayout. BUG=657650 ==========
spqchan@chromium.org changed reviewers: + avi@chromium.org
spqchan@chromium.org changed reviewers: - avi@chromium.org
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
The CQ bit was unchecked by spqchan@chromium.org
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
spqchan@chromium.org changed reviewers: + rohitrao@chromium.org
PTAL
On 2016/10/28 03:32:15, spqchan wrote: > PTAL ping :)
lgtm
On 2016/10/31 19:10:06, rohitrao wrote: > lgtm thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix security chip page load issue Make sure that |is_width_available_for_security_verbose_| is always updated when the omnibox is relayout. BUG=657650 ========== to ========== [Mac] Fix security chip page load issue Make sure that |is_width_available_for_security_verbose_| is always updated when the omnibox is relayout. BUG=657650 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix security chip page load issue Make sure that |is_width_available_for_security_verbose_| is always updated when the omnibox is relayout. BUG=657650 ========== to ========== [Mac] Fix security chip page load issue Make sure that |is_width_available_for_security_verbose_| is always updated when the omnibox is relayout. BUG=657650 Committed: https://crrev.com/dedfa14969151652438f5a2795f5b4889714f20b Cr-Commit-Position: refs/heads/master@{#428771} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/dedfa14969151652438f5a2795f5b4889714f20b Cr-Commit-Position: refs/heads/master@{#428771} |
