Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: milo/appengine/swarming/memoryClient.go

Issue 2456953003: LogDog: Update client/bootstrap to generate URLs. (Closed)
Patch Set: Winders Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/common/viewer/url_test.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/swarming/memoryClient.go
diff --git a/milo/appengine/swarming/memoryClient.go b/milo/appengine/swarming/memoryClient.go
index ba845b8ee6ce36ee08456d2de17e7390d5f72d3f..80e3cf0f0ab83edae227c191007b1e31b4349962 100644
--- a/milo/appengine/swarming/memoryClient.go
+++ b/milo/appengine/swarming/memoryClient.go
@@ -17,7 +17,7 @@ import (
// In-memory datastructure to hold a fake butler client.
type memoryStream struct {
- *streamproto.Properties
+ props *streamproto.Properties
closed bool
buf bytes.Buffer
@@ -28,8 +28,8 @@ func (s *memoryStream) ToLogDogStream() (*logdog.Stream, error) {
result := &logdog.Stream{
Closed: s.closed,
IsDatagram: s.isDatagram,
- Path: s.Name,
- Prefix: s.Prefix,
+ Path: s.props.Name,
+ Prefix: s.props.Prefix,
}
if s.isDatagram {
@@ -62,6 +62,8 @@ func (s *memoryStream) WriteDatagram(b []byte) error {
return err
}
+func (s *memoryStream) Properties() *streamproto.Properties { return s.props.Clone() }
+
type memoryClient struct {
stream map[string]*memoryStream
}
@@ -72,12 +74,12 @@ func (c *memoryClient) NewStream(f streamproto.Flags) (streamclient.Stream, erro
return nil, fmt.Errorf("duplicate stream, %q", props.Name)
}
s := memoryStream{
- Properties: props,
+ props: props,
}
if c.stream == nil {
c.stream = map[string]*memoryStream{}
}
- c.stream[s.Name] = &s
+ c.stream[s.props.Name] = &s
return &s, nil
}
« no previous file with comments | « logdog/common/viewer/url_test.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698