Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: logdog/client/butlerlib/streamproto/properties_test.go

Issue 2456953003: LogDog: Update client/bootstrap to generate URLs. (Closed)
Patch Set: Winders Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/client/butlerlib/streamproto/properties_test.go
diff --git a/logdog/client/butlerlib/streamproto/properties_test.go b/logdog/client/butlerlib/streamproto/properties_test.go
index 58fc3cd7dbf7249b62cd764df83763e581c1c78f..4bc6a02bdc1336aebe40e26aac9aca7b7a51e5ac 100644
--- a/logdog/client/butlerlib/streamproto/properties_test.go
+++ b/logdog/client/butlerlib/streamproto/properties_test.go
@@ -24,7 +24,9 @@ func TestProperties(t *testing.T) {
Convey(`A testing instance`, t, func() {
ctx, _ := testclock.UseTime(context.Background(), time.Date(2015, 1, 1, 0, 0, 0, 0, time.UTC))
Convey(`A Properties instance with no ContentType`, func() {
- p := Properties{}
+ p := Properties{
+ LogStreamDescriptor: &logpb.LogStreamDescriptor{},
+ }
Convey(`Returns the configured ContentType if one is set.`, func() {
p.ContentType = "foo/bar"
@@ -61,7 +63,7 @@ func TestFlags(t *testing.T) {
Convey(`Converts to Properties.`, func() {
p := f.Properties()
So(p, ShouldResemble, &Properties{
- LogStreamDescriptor: logpb.LogStreamDescriptor{
+ LogStreamDescriptor: &logpb.LogStreamDescriptor{
Name: "my/stream",
ContentType: "foo/bar",
StreamType: logpb.StreamType_TEXT,
@@ -80,7 +82,7 @@ func TestFlagsJSON(t *testing.T) {
So(json.Unmarshal([]byte(t), &f), ShouldBeNil)
So(f.Properties(), ShouldResemble, &Properties{
- LogStreamDescriptor: logpb.LogStreamDescriptor{
+ LogStreamDescriptor: &logpb.LogStreamDescriptor{
Name: "my/stream",
ContentType: "foo/bar",
StreamType: logpb.StreamType_TEXT,
@@ -99,7 +101,7 @@ func TestFlagsJSON(t *testing.T) {
So(json.Unmarshal([]byte(t), &f), ShouldBeNil)
So(f.Properties(), ShouldResemble, &Properties{
- LogStreamDescriptor: logpb.LogStreamDescriptor{
+ LogStreamDescriptor: &logpb.LogStreamDescriptor{
Name: "my/stream",
StreamType: logpb.StreamType_BINARY,
ContentType: string(types.ContentTypeBinary),
@@ -113,7 +115,7 @@ func TestFlagsJSON(t *testing.T) {
So(json.Unmarshal([]byte(t), &f), ShouldBeNil)
So(f.Properties(), ShouldResemble, &Properties{
- LogStreamDescriptor: logpb.LogStreamDescriptor{
+ LogStreamDescriptor: &logpb.LogStreamDescriptor{
Name: "my/stream",
StreamType: logpb.StreamType_DATAGRAM,
ContentType: string(types.ContentTypeLogdogDatagram),
« no previous file with comments | « logdog/client/butlerlib/streamproto/properties.go ('k') | logdog/client/cmd/logdog_annotee/filesystemClient.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698