logdog/client/butlerlib/streamclient/local.go - Issue 2456953003: LogDog: Update client/bootstrap to generate URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: logdog/client/butlerlib/streamclient/local.go

Issue 2456953003: LogDog: Update client/bootstrap to generate URLs. (Closed)

Patch Set: Better comments, use "url.URL". Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: logdog/client/butlerlib/streamclient/local.go

diff --git a/logdog/client/butlerlib/streamclient/local.go b/logdog/client/butlerlib/streamclient/local.go

index c9114db40b4809982c3928d06348e9835684ec32..cbfda96251f90de577c8fcbde44b460390bb2b5f 100644

--- a/logdog/client/butlerlib/streamclient/local.go

+++ b/logdog/client/butlerlib/streamclient/local.go

@@ -38,12 +38,12 @@ func (c *localClient) NewStream(f streamproto.Flags) (s Stream, err error) {

props := f.Properties()

stream := streamImpl{

- Properties: props,

WriteCloser: pw,

+ props: props,

}

// Add the Stream to the Butler.

- if err = c.AddStream(pr, *props); err != nil {

+ if err = c.AddStream(pr, props); err != nil {

return

}

return &stream, nil