Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2456923002: Revert of Add libgtk3ui to gn_all (Closed)

Created:
4 years, 1 month ago by Tom (Use chromium acct)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, Elliot Glaysher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add libgtk3ui to gn_all (patchset #3 id:40001 of https://codereview.chromium.org/2455863002/ ) Reason for revert: Breaks gn gen with the following args.gn: use_aura = true use_ozone = true ozone_auto_platforms = false ozone_platform = "headless" ozone_platform_headless = true metrics_use_blimp = true use_low_quality_image_interpolation = true use_external_popup_menu = true use_alsa = false use_pulseaudio = false use_cups = false use_glib = false use_udev = false is_debug = true use_goma = true is_component_build = true Original issue's description: > Add libgtk3ui to gn_all > > BUG=132847 > > Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93 > Cr-Commit-Position: refs/heads/master@{#428090} TBR=dpranke@chromium.org,erg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=132847 Committed: https://crrev.com/379c250a827a45005aebef44028880d94d222e87 Cr-Commit-Position: refs/heads/master@{#428120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Tom (Use chromium acct)
Created Revert of Add libgtk3ui to gn_all
4 years, 1 month ago (2016-10-27 19:56:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456923002/1
4 years, 1 month ago (2016-10-27 19:57:08 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-27 19:57:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456923002/1
4 years, 1 month ago (2016-10-27 19:58:24 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-27 19:58:29 UTC) #9
Tom Anderson
lgtm lgtm
4 years, 1 month ago (2016-10-27 19:58:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456923002/1
4 years, 1 month ago (2016-10-27 19:59:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 20:01:25 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/379c250a827a45005aebef44028880d94d222e87 Cr-Commit-Position: refs/heads/master@{#428120}
4 years, 1 month ago (2016-10-27 20:05:05 UTC) #16
Dirk Pranke
4 years, 1 month ago (2016-10-27 20:57:38 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698