Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2456893002: Remove careOf field from PaymentAddress. (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, haraken, sebsg+paymentswatch_chromium.org, rouslan+payments_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove careOf field from PaymentAddress. Intent to deprecate and remove in M56: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80 Feature dashboard: https://www.chromestatus.com/feature/5728579069411328 BUG=648049 Committed: https://crrev.com/64b394a9db0ef6ba58279c5fc26a3dbce4324bdb Cr-Commit-Position: refs/heads/master@{#428195}

Patch Set 1 #

Patch Set 2 : Remove use counter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
please use gerrit instead
foolip, ptal
4 years, 1 month ago (2016-10-27 20:35:57 UTC) #5
foolip
lgtm
4 years, 1 month ago (2016-10-27 21:23:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456893002/20001
4 years, 1 month ago (2016-10-27 21:25:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 23:14:49 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:20:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64b394a9db0ef6ba58279c5fc26a3dbce4324bdb
Cr-Commit-Position: refs/heads/master@{#428195}

Powered by Google App Engine
This is Rietveld 408576698