MD History: fix script errors when navigating to /syncedTabs (or refreshing)

MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40
Cr-Commit-Position: refs/heads/master@{#429478}

[Dan Beam, 2016-10-28 00:42:34]

Description was changed from

==========
MD History: fix script errors when loading /syncedTabs

Also simplifies handling of sign in changes (and de-duplicates handling
methods).

R=lshang@chromium.org
BUG=659487
==========

to

==========
MD History: fix script errors when loading /syncedTabs

Also simplifies handling of sign in changes (and de-duplicates handling
methods).

R=lshang@chromium.org
BUG=659487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-11-02 06:13:34]

tsergeant@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-11-02 06:13:35]

Is this necessary to fix the image error, or is this an separate issue? Either
way, can you add crbug.com/651707 to the BUG= line?

Delaying loading the router is not ideal, since the <history-list> will now be
fully loaded before the page switches to the synced-device-manager. This means
that there's a flash of fully rendered <history-list> before the
synced-device-manager renders (and a corresponding drop in performance)

One alternative way to fix this is to wait for lazy load to complete at the
point where the error is taking place. In historyViewChanged_:

      md_history.ensureLazyLoaded().then(function() {
        this.scrollTarget =
            this.$.content.selectedItem.getContentScrollTarget();
        this._scrollHandler();
      }.bind(this));

This seems to work OK for me locally, and since the same promise is reused it
will work correctly with existing lazy-loading.

[Dan Beam, 2016-11-02 16:54:36]

Description was changed from

==========
MD History: fix script errors when loading /syncedTabs

Also simplifies handling of sign in changes (and de-duplicates handling
methods).

R=lshang@chromium.org
BUG=659487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: fix script errors when loading /syncedTabs

Also simplifies handling of sign in changes (and de-duplicates handling
methods).

R=lshang@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-02 22:16:50]

Description was changed from

==========
MD History: fix script errors when loading /syncedTabs

Also simplifies handling of sign in changes (and de-duplicates handling
methods).

R=lshang@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: simplify sign in updates

Re-uses existing updateSignInState which already waits for upgrades.

R=lshang@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-11-02 22:30:46]

So, this is now purely a simplification, with no behavioral change?

https://codereview.chromium.org/2456783006/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/2456783006/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:27: WebUIListenerBehavior,
Can this be removed now?

[Dan Beam, 2016-11-02 22:44:20]

Description was changed from

==========
MD History: simplify sign in updates

Re-uses existing updateSignInState which already waits for upgrades.

R=lshang@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=lshang@chromium.org,tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-02 22:48:40]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2016-11-02 22:49:11]

https://codereview.chromium.org/2456783006/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/2456783006/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:27: WebUIListenerBehavior,
On 2016/11/02 22:30:46, tsergeant wrote:
> Can this be removed now?

Done.

[commit-bot: I haz the power, 2016-11-02 22:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-02 22:49:37]

On 2016/11/02 22:30:46, tsergeant wrote:
> So, this is now purely a simplification, with no behavioral change?

i've updated the CL (again) to say "let's just fix all script errors in this CL"

[Dan Beam, 2016-11-02 23:00:49]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 23:01:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-11-02 23:23:48]

lgtm

[Dan Beam, 2016-11-02 23:29:11]

Description was changed from

==========
MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=lshang@chromium.org,tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-02 23:29:11]

dbeam@chromium.org changed reviewers:
- lshang@chromium.org

[Dan Beam, 2016-11-02 23:29:20]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-11-02 23:29:26]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-11-02 23:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 00:36:05]

Description was changed from

==========
MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-03 00:36:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-03 00:40:21]

Description was changed from

==========
MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: fix script errors when navigating to /syncedTabs (or refreshing)

Also simplifies sign in state changes by re-using existing
updateSignInState method (which already exists and waits for upgrades).

R=tsergeant@chromium.org
BUG=651707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40
Cr-Commit-Position: refs/heads/master@{#429478}
==========

[commit-bot: I haz the power, 2016-11-03 00:40:22]

Patchset 4 (id:??) landed as
https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40
Cr-Commit-Position: refs/heads/master@{#429478}