[ash-md] Changed the style of ink drop applied to system menu icon buttons.

ash/common/system/tray/system_menu_button.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SYSTEM_TRAY_SYSTEM_MENU_BUTTON_H_
 #define ASH_COMMON_SYSTEM_TRAY_SYSTEM_MENU_BUTTON_H_
 
 #include "ash/resources/vector_icons/vector_icons.h"
 #include "base/macros.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/button/image_button.h"
 
-namespace views {
-class InkDropHighlight;
-class InkDropRipple;
-}
-
 namespace ash {
 
 // A 48x48 image button with a material design ripple effect, which can be
 // used across Ash material design native UI menus.
 // TODO(tdanderson): Deprecate TrayPopupHeaderButton in favor of
 // SystemMenuButton once material design is enabled by default. See
 // crbug.com/614453.
 class SystemMenuButton : public views::ImageButton {
  public:
+  // The different ink drop styles that can be used.
+  enum class InkDropStyle { SQUARE, FLOOD_FILL };
+
   // Constructs the button with |listener| and a centered icon corresponding to
-  // |icon|. |accessible_name_id| corresponds to the string in
+  // |icon|. |ink_drop_style| specifies which flavor of the ink drop should be
+  // used. |accessible_name_id| corresponds to the string in
   // ui::ResourceBundle to use for the button's accessible and tooltip text.
   SystemMenuButton(views::ButtonListener* listener,
+                   InkDropStyle ink_drop_style,
                    const gfx::VectorIcon& icon,
                    int accessible_name_id);
   ~SystemMenuButton() override;
 
   // views::ImageButton:
   std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override;
   std::unique_ptr<views::InkDropHighlight> CreateInkDropHighlight()
       const override;
-  bool ShouldShowInkDropForFocus() const override;
+  bool ShouldShowInkDropHighlight() const override;
 
  private:
+  // Returns the size that the ink drop should be constructed with.
+  gfx::Size GetInkDropSize() const;
+
+  // Defines the flavor of ink drop ripple/highlight that should be constructed.

[tdanderson, 2016/10/27 21:21:41]

Consider including a brief mention of why one would want to choose one over the
other (e.g., flood fill for separator-bounded buttons, square otherwise)

[bruthig, 2016/10/27 21:34:30]

Done, added to the enum.

+  InkDropStyle ink_drop_style_ = InkDropStyle::SQUARE;

[tdanderson, 2016/10/27 21:21:41]

nit: I don't think initialization here is necessary. There is only one
constructor, and it takes in and initializes the ink drop style.

[bruthig, 2016/10/27 21:34:31]

Removed.

+
   DISALLOW_COPY_AND_ASSIGN(SystemMenuButton);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SYSTEM_TRAY_SYSTEM_MENU_BUTTON_H_