Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2456783004: Revert of Overwrite the HeapVector of ShippingOptions for more clear code. (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, rouslan+payments_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Overwrite the HeapVector of ShippingOptions for more clear code. (patchset #2 id:20001 of https://codereview.chromium.org/2444493002/ ) Reason for revert: Breaks CFI. https://bugs.chromium.org/p/chromium/issues/detail?id=659885 Original issue's description: > Overwrite the HeapVector of ShippingOptions for more clear code. > > BUG=600808 > > Committed: https://crrev.com/e177f658f2b6ab19fac1885586f2b25bf9975aa8 > Cr-Commit-Position: refs/heads/master@{#427181} TBR=haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=600808 Committed: https://crrev.com/38c1be9dce77296f2336d8dd64f7e0e1809f2dfa Cr-Commit-Position: refs/heads/master@{#428008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -35 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 8 chunks +57 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
please use gerrit instead
Created Revert of Overwrite the HeapVector of ShippingOptions for more clear code.
4 years, 1 month ago (2016-10-27 11:45:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456783004/1
4 years, 1 month ago (2016-10-27 11:45:13 UTC) #3
haraken
LGTM
4 years, 1 month ago (2016-10-27 11:54:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 13:14:31 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 13:16:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38c1be9dce77296f2336d8dd64f7e0e1809f2dfa
Cr-Commit-Position: refs/heads/master@{#428008}

Powered by Google App Engine
This is Rietveld 408576698