Issue 2456763002: Merged: [compiler] Properly validate stable map assumption for globals.

Issue 2456763002: Merged: [compiler] Properly validate stable map assumption for globals. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer

Modified:
4 years, 1 month ago

Reviewers:
Yang

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan

Target Ref:
refs/pending/branch-heads/5.4

Project:
v8

Visibility:
Public.

Merged: [compiler] Properly validate stable map assumption for globals. Revision: 2bd7464ec1efc9eb24a38f7400119a5f2257f6e6 BUG=chromium:659475 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=yangguo@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2aa98cc12ccd5c5a4e082e94383b851eade89ac2

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -9 lines)			Patch
M	src/bailout-reason.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/js-global-object-specialization.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/crankshaft/hydrogen.cc	View	1 chunk	+12 lines, -4 lines	0 comments	Download
M	src/runtime/runtime-utils.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-659475-1.js	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-659475-2.js	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Benedikt Meurer

NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...

4 years, 1 month ago (2016-10-27 04:23:37 UTC) #2

Benedikt Meurer

Committed patchset #1 (id:1) manually as 2aa98cc12ccd5c5a4e082e94383b851eade89ac2.

4 years, 1 month ago (2016-10-27 04:28:44 UTC) #4

Yang

4 years, 1 month ago (2016-10-27 05:14:56 UTC) #5

Message was sent while issue was closed.

On 2016/10/27 04:28:44, Benedikt Meurer wrote:
> Committed patchset #1 (id:1) manually as
> 2aa98cc12ccd5c5a4e082e94383b851eade89ac2.

lgtm.