third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h - Issue 2456733002: DevTools: Make WorkerThreadDebugger available for Worklets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h

Issue 2456733002: DevTools: Make WorkerThreadDebugger available for Worklets (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h

diff --git a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h b/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h

index 52ed15cba20f1f22b60e1ddd8abea2b42a0c98f3..9e806fb8d7471eaf09c9f5a2031061757779af59 100644

--- a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h

+++ b/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h

@@ -25,8 +25,6 @@ class MODULES_EXPORT AbstractAnimationWorkletThread : public WorkerThread {

// The backing thread is cleared by clearSharedBackingThread().

void clearWorkerBackingThread() override {}

- bool shouldAttachThreadDebugger() const override { return false; }

// This may block the main thread.

static void collectAllGarbage();