pkg/docgen: a bunch of cleanup

pkg/docgen/lib/src/models/dummy_mirror.dart

Index: pkg/docgen/lib/src/models/dummy_mirror.dart
diff --git a/pkg/docgen/lib/src/models/dummy_mirror.dart b/pkg/docgen/lib/src/models/dummy_mirror.dart
index 0631a807a7903cb0cf0af8932e32645400d77581..9ad612a4804cdb36aaa1c8b829e65d1858bb5f6c 100644
--- a/pkg/docgen/lib/src/models/dummy_mirror.dart
+++ b/pkg/docgen/lib/src/models/dummy_mirror.dart
@@ -24,9 +24,8 @@ class DummyMirror implements Indexable {
   DummyMirror(this.mirror, [this.owner]);
 
   String get docName {
-    if (mirror == null) return '';

[kevmoo, 2014/04/21 19:22:19]

With the change to Library have it's own "fake" Indexable for its owner, we can
now assume that all DummyMirror instances have a non-null owner

     if (mirror is LibraryMirror) {
-      return dart2js_util.qualifiedNameOf(mirror).replaceAll('.', '-');

[kevmoo, 2014/04/21 19:22:19]

Moved to shared method since this logic also exists in Library

+      return getLibraryDocName(mirror);
     }
     var mirrorOwner = mirror.owner;
     if (mirrorOwner == null) return dart2js_util.qualifiedNameOf(mirror);
@@ -40,7 +39,7 @@ class DummyMirror implements Indexable {
         simpleName;
   }
 
-  bool get isPrivate => mirror == null ? false : mirror.isPrivate;
+  bool get isPrivate => mirror.isPrivate;
 
   String get packageName {
     var libMirror = _getOwningLibraryFromMirror(mirror);
@@ -53,13 +52,15 @@ class DummyMirror implements Indexable {
   String get packagePrefix => packageName == null || packageName.isEmpty ?
       '' : '$packageName/';
 
-  LibraryMirror _getOwningLibraryFromMirror(DeclarationMirror mirror) {
-    if (mirror is LibraryMirror) return mirror;
-    if (mirror == null) return null;
-    return _getOwningLibraryFromMirror(mirror.owner);
-  }
-
+  // This is a known incomplete implementation of Indexable
+  // overriding noSuchMethod to remove static warnings
   noSuchMethod(Invocation invocation) {
     throw new UnimplementedError(invocation.memberName.toString());
   }
 }
+
+LibraryMirror _getOwningLibraryFromMirror(DeclarationMirror mirror) {
+  if (mirror == null) return null;
+  if (mirror is LibraryMirror) return mirror;
+  return _getOwningLibraryFromMirror(mirror.owner);
+}