Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: pkg/docgen/lib/src/generator.dart

Issue 245673002: pkg/docgen: a bunch of cleanup (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/docgen/lib/src/library_helpers.dart » ('j') | pkg/docgen/lib/src/library_helpers.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/docgen/lib/src/generator.dart
diff --git a/pkg/docgen/lib/src/generator.dart b/pkg/docgen/lib/src/generator.dart
index 7d8bc080afdf099c05564bb0efd04285750251ed..9778b519565d04de62f1e56983bc099a02735531 100644
--- a/pkg/docgen/lib/src/generator.dart
+++ b/pkg/docgen/lib/src/generator.dart
@@ -183,15 +183,11 @@ void _documentLibraries(List<LibraryMirror> libs, bool includeSdk,
});
var filteredEntities = new SplayTreeSet<Indexable>(_indexableComparer);
- for (Map<String, Set<Indexable>> firstLevel in mirrorToDocgen.values) {
- for (Set<Indexable> items in firstLevel.values) {
- for (Indexable item in items) {
- if (isFullChainVisible(item)) {
- if (item is! Method ||
- (item is Method && item.methodInheritedFrom == null)) {
- filteredEntities.add(item);
- }
- }
+ for (Indexable item in allIndexables) {
kevmoo 2014/04/21 19:22:19 Exposed in Indexable
+ if (isFullChainVisible(item)) {
+ if (item is! Method ||
+ (item is Method && item.methodInheritedFrom == null)) {
+ filteredEntities.add(item);
}
}
}
@@ -245,7 +241,7 @@ void _writeOutputFiles(Map<String, dynamic> libraryMap, Iterable<Indexable>
/// Helper method to serialize the given Indexable out to a file.
void _writeIndexableToFile(Indexable result, JsonEncoder encoder) {
- var outputFile = result.fileName + '.json';
+ var outputFile = result.qualifiedName + '.json';
var output = encoder.convert(result.toMap());
_writeToFile(output, outputFile);
}
« no previous file with comments | « no previous file | pkg/docgen/lib/src/library_helpers.dart » ('j') | pkg/docgen/lib/src/library_helpers.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698