Move VariationsParamAssociator to base

Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc. This is so we can eventually get field trial parameters into child processes using shared memory.

BUG=660038
Committed: https://crrev.com/5d5ac0c30be692e2e918121e140a869af36f8dc2
Cr-Commit-Position: refs/heads/master@{#428710}

[lawrencewu, 2016-10-27 17:15:14]

lawrencewu@chromium.org changed reviewers:
+ asvitkine@chromium.org

[lawrencewu, 2016-10-27 17:15:14]

First step of the plan to eventually get params into base.

[Alexei Svitkine (slow), 2016-10-28 15:39:17]

Looks good, just a few comments.

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
File base/metrics/field_trial_param_associator.cc (right):

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.cc:1: // Copyright (c) 2016 The
Chromium Authors. All rights reserved.
No (c)

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
File base/metrics/field_trial_param_associator.h (right):

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:1: // Copyright (c) 2016 The
Chromium Authors. All rights reserved.
Nit: No (c) for new files

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:14: #include
"base/metrics/field_trial.h"
Is this used in the header? If not, move to the cc.

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:24: FieldTrialKey;  //
(FieldTrialName, FieldTrialGroup)
Can this be in the private section?

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:37: void ClearAllParamsForTesting();
Please add comments above all the public functions since this is now a public
header file.

[lawrencewu, 2016-10-28 16:54:28]

lawrencewu@chromium.org changed reviewers:
+ dcheng@chromium.org

[lawrencewu, 2016-10-28 16:54:29]

Address comments.

@dcheng, would you mind taking a look at the new BUILD.gn file? Thanks in
advance.

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
File base/metrics/field_trial_param_associator.cc (right):

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.cc:1: // Copyright (c) 2016 The
Chromium Authors. All rights reserved.
On 2016/10/28 15:39:16, Alexei Svitkine (slow) wrote:
> No (c)

Done.

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
File base/metrics/field_trial_param_associator.h (right):

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:1: // Copyright (c) 2016 The
Chromium Authors. All rights reserved.
On 2016/10/28 15:39:17, Alexei Svitkine (slow) wrote:
> Nit: No (c) for new files

Done.

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:14: #include
"base/metrics/field_trial.h"
On 2016/10/28 15:39:17, Alexei Svitkine (slow) wrote:
> Is this used in the header? If not, move to the cc.

Done.

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:24: FieldTrialKey;  //
(FieldTrialName, FieldTrialGroup)
On 2016/10/28 15:39:17, Alexei Svitkine (slow) wrote:
> Can this be in the private section?

Done.

https://codereview.chromium.org/2456723004/diff/1/base/metrics/field_trial_pa...
base/metrics/field_trial_param_associator.h:37: void ClearAllParamsForTesting();
On 2016/10/28 15:39:17, Alexei Svitkine (slow) wrote:
> Please add comments above all the public functions since this is now a public
> header file.

Done.

[lawrencewu, 2016-10-28 16:54:52]

Description was changed from

==========
Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc

BUG=660038
==========

to

==========
Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc. This is so we can eventually
get field trial parameters into child processes using shared memory.

BUG=660038
==========

[dcheng, 2016-10-28 17:38:15]

//base LGTM

[Alexei Svitkine (slow), 2016-10-28 18:46:33]

lgtm

[lawrencewu, 2016-10-28 18:50:46]

The CQ bit was checked by lawrencewu@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:59:08]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lawrencewu, 2016-10-30 20:40:49]

The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 20:41:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 22:01:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 22:01:34]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[lawrencewu, 2016-10-31 13:52:06]

The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 13:52:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 14:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 14:47:22]

Dry run: This issue passed the CQ dry run.

[lawrencewu, 2016-10-31 14:47:32]

The CQ bit was checked by lawrencewu@chromium.org

[lawrencewu, 2016-10-31 14:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2456723004/#ps60001
(title: "rebase-update")

[commit-bot: I haz the power, 2016-10-31 14:47:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 14:52:37]

Description was changed from

==========
Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc. This is so we can eventually
get field trial parameters into child processes using shared memory.

BUG=660038
==========

to

==========
Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc. This is so we can eventually
get field trial parameters into child processes using shared memory.

BUG=660038
==========

[commit-bot: I haz the power, 2016-10-31 14:52:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-31 14:55:01]

Description was changed from

==========
Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc. This is so we can eventually
get field trial parameters into child processes using shared memory.

BUG=660038
==========

to

==========
Move VariationsParamAssociator to base

Moves VariationsParamAssociator to base as FieldTrialParamAssociator
and just reroutes the calls in variations_associated_data.cc to this
new class in field_trial_param_associator.h/.cc. This is so we can eventually
get field trial parameters into child processes using shared memory.

BUG=660038

Committed: https://crrev.com/5d5ac0c30be692e2e918121e140a869af36f8dc2
Cr-Commit-Position: refs/heads/master@{#428710}
==========

[commit-bot: I haz the power, 2016-10-31 14:55:02]

Patchset 4 (id:??) landed as
https://crrev.com/5d5ac0c30be692e2e918121e140a869af36f8dc2
Cr-Commit-Position: refs/heads/master@{#428710}