Server push cancellation: add methods in session layer to cancel push given the pushed url. Not in …

net/quic/core/quic_client_session_base.h

Index: net/quic/core/quic_client_session_base.h
diff --git a/net/quic/core/quic_client_session_base.h b/net/quic/core/quic_client_session_base.h
index f73081f72aa54fb644d26c6639343b6bda89bf47..7b919a2b6cf72fef943b394ac6f66b4ee35e79ae 100644
--- a/net/quic/core/quic_client_session_base.h
+++ b/net/quic/core/quic_client_session_base.h
@@ -111,6 +111,9 @@ class NET_EXPORT_PRIVATE QuicClientSessionBase
   // control accounting).
   void ResetPromised(QuicStreamId id, QuicRstStreamErrorCode error_code);
 
+  // Cancels the push if the push stream is unclaimed and active.
+  virtual void CancelPush(const GURL& url);

[Ryan Hamilton, 2016/10/27 17:00:25]

I don't think I understand why we need this method here since the .cc file has a
no-op implementation. I'm guessing this is some sort of polymorphism mechanism?

[Zhongyi Shi, 2016/10/27 17:57:30]

You are right. I don't need this anymore. I was thinking to make this function
more general so that we could also call it when push times out (which then
requires QuicClientSessionBase to have the method). Then I gave up... So yeah,
removing it now. Thanks for catching it!

+
   // Release headers stream's sequencer buffer if it's empty.
   void CloseStreamInner(QuicStreamId stream_id, bool locally_reset) override;