Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2456673002: Update focus when widget changes visibility. (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update focus when widget changes visibility. ChromeVox wasn't getting a notification that the focused view changed when the find bar was hidden. Fix this by firing a focus event whenever a widget's visibility changes. Existing code already ensures that the event gets fired on the right view and that no duplicate events are generated by the time it gets to ChromeVox. BUG=659813 Committed: https://crrev.com/17670ecf0ddf150c6a16d611e154d184fa6c27a7 Cr-Commit-Position: refs/heads/master@{#427906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M ui/views/accessibility/ax_aura_obj_cache.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dmazzoni
4 years, 1 month ago (2016-10-26 22:05:12 UTC) #2
David Tseng
lgtm
4 years, 1 month ago (2016-10-27 01:18:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456673002/1
4 years, 1 month ago (2016-10-27 01:18:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 01:26:28 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 01:29:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17670ecf0ddf150c6a16d611e154d184fa6c27a7
Cr-Commit-Position: refs/heads/master@{#427906}

Powered by Google App Engine
This is Rietveld 408576698