Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2456653003: Add entries for some Xbox One gamepads supported by 360Controller (Closed)

Created:
4 years, 1 month ago by cgutman
Modified:
4 years, 1 month ago
Reviewers:
bajones, scottmg
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add entries for some Xbox One gamepads supported by 360Controller The 360Controller driver exposes Xbox 360-compatible mappings for Xbox One gamepads. This adds mapping entries for several of the most common first-party Xbox One gamepads. BUG=655037 TEST=http://html5gamepad.com/ Committed: https://crrev.com/25521a0137c99d98cf1cd10243070d8c767d6b06 Cr-Commit-Position: refs/heads/master@{#428208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M device/gamepad/gamepad_standard_mappings_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
cgutman
4 years, 1 month ago (2016-10-27 17:55:10 UTC) #3
bajones
LGTM, especially considering the popularity of the gamepad.
4 years, 1 month ago (2016-10-27 22:26:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456653003/1
4 years, 1 month ago (2016-10-27 22:52:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 23:28:37 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:32:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25521a0137c99d98cf1cd10243070d8c767d6b06
Cr-Commit-Position: refs/heads/master@{#428208}

Powered by Google App Engine
This is Rietveld 408576698