Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2456643006: More functionality in kernel_impact. (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Updated cf. comment #

Patch Set 4 : Rebased #

Patch Set 5 : Fix errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -95 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_debug.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 chunks +15 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 2 chunks +22 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 4 chunks +17 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 6 chunks +114 lines, -31 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 12 chunks +207 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Johnni Winther
4 years, 1 month ago (2016-10-28 08:20:13 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2456643006/diff/20001/pkg/compiler/lib/src/resolution/registry.dart File pkg/compiler/lib/src/resolution/registry.dart (right): https://codereview.chromium.org/2456643006/diff/20001/pkg/compiler/lib/src/resolution/registry.dart#newcode334 pkg/compiler/lib/src/resolution/registry.dart:334: /// Register checked mode check of [type] if ...
4 years, 1 month ago (2016-10-31 20:33:37 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as a0bccd5c88a94d91aec03cd1eb3a7c26ab2c6091 (presubmit successful).
4 years, 1 month ago (2016-11-01 11:37:42 UTC) #5
Johnni Winther
https://codereview.chromium.org/2456643006/diff/20001/pkg/compiler/lib/src/resolution/registry.dart File pkg/compiler/lib/src/resolution/registry.dart (right): https://codereview.chromium.org/2456643006/diff/20001/pkg/compiler/lib/src/resolution/registry.dart#newcode334 pkg/compiler/lib/src/resolution/registry.dart:334: /// Register checked mode check of [type] if isn't ...
4 years, 1 month ago (2016-11-01 11:38:19 UTC) #6
Johnni Winther
PTAL @ the last patch
4 years, 1 month ago (2016-11-02 13:39:56 UTC) #8
Johnni Winther
Committed patchset #5 (id:80001) manually as 2ad261654327d64b853c3e6d8e8a82c9d8840092 (presubmit successful).
4 years, 1 month ago (2016-11-02 13:42:24 UTC) #10
Harry Terkelsen
4 years, 1 month ago (2016-11-02 16:49:03 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698