Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/ui_devtools/devtools_client.h

Issue 2456643002: Create a base agent class for ui_devtools (Closed)
Patch Set: sadruls comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ui_devtools/devtools_base_agent.h ('k') | components/ui_devtools/devtools_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ui_devtools/devtools_client.h
diff --git a/components/ui_devtools/devtools_client.h b/components/ui_devtools/devtools_client.h
index c4ccb7a09ff4b697b70df5a6ab6e12cd1e849472..3c852bfe948fcaa767a9b67b4ab07d2af3d74afe 100644
--- a/components/ui_devtools/devtools_client.h
+++ b/components/ui_devtools/devtools_client.h
@@ -10,6 +10,7 @@
#include "components/ui_devtools/DOM.h"
#include "components/ui_devtools/Forward.h"
#include "components/ui_devtools/Protocol.h"
+#include "components/ui_devtools/devtools_base_agent.h"
namespace ui {
namespace devtools {
@@ -27,7 +28,9 @@ class UiDevToolsClient : public protocol::FrontendChannel {
UiDevToolsClient(const std::string& name, UiDevToolsServer* server);
~UiDevToolsClient() override;
- void AddDOMBackend(std::unique_ptr<protocol::DOM::Backend> dom_backend);
+ void AddAgent(std::unique_ptr<UiDevToolsAgent> agent);
+ // TODO(mhashmi): Remove when ash is updated to use the new base agent
+ void AddDOMBackend(std::unique_ptr<protocol::DOM::Backend> backend);
void Dispatch(const std::string& data);
bool connected() const;
@@ -43,6 +46,7 @@ class UiDevToolsClient : public protocol::FrontendChannel {
std::string name_;
int connection_id_;
+ std::vector<std::unique_ptr<UiDevToolsAgent>> agents_;
std::unique_ptr<protocol::DOM::Backend> dom_backend_;
protocol::UberDispatcher dispatcher_;
UiDevToolsServer* server_;
« no previous file with comments | « components/ui_devtools/devtools_base_agent.h ('k') | components/ui_devtools/devtools_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698