Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2456633002: Narrow next compat whitelist (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Narrow next compat whitelist Specifically whitelist docs, sheets, and presentations for next compat. TEST=visit a Google form I created with radiobuttons (docs.google.com/form/...); verify next is running and that next reads radio state (was a classic bug). BUG=656463, 628969 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/11a00d5d5473b898435cabce8b7b7bb5bbc37714 Cr-Commit-Position: refs/heads/master@{#428928}

Patch Set 1 #

Total comments: 1

Patch Set 2 : indent #

Patch Set 3 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
David Tseng
4 years, 1 month ago (2016-10-26 20:23:46 UTC) #4
dmazzoni
lgtm https://codereview.chromium.org/2456633002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js (right): https://codereview.chromium.org/2456633002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js#newcode80 chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:80: '*docs.google.com/presentation/*' nit: indentation
4 years, 1 month ago (2016-10-31 19:48:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456633002/20001
4 years, 1 month ago (2016-10-31 23:33:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/263663)
4 years, 1 month ago (2016-11-01 01:19:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456633002/40001
4 years, 1 month ago (2016-11-01 02:46:55 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-01 03:38:04 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 03:40:24 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/11a00d5d5473b898435cabce8b7b7bb5bbc37714
Cr-Commit-Position: refs/heads/master@{#428928}

Powered by Google App Engine
This is Rietveld 408576698