Do not mark alternate-protocol broken unless the main job succeeds.

net/http/http_stream_factory_impl_job.h

Index: net/http/http_stream_factory_impl_job.h
diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h
index d4406477f7ea5c6435d7ee74eaf2422da7457433..6d3d04415d486d617e623b5eafb69c112d52ddfd 100644
--- a/net/http/http_stream_factory_impl_job.h
+++ b/net/http/http_stream_factory_impl_job.h
@@ -96,6 +96,9 @@ class HttpStreamFactoryImpl::Job {
   // will be orphaned.
   void ReportJobSuccededForRequest();
 
+  // Marks that the other job |job| has completed.

[willchan no longer on Chromium, 2014/04/22 21:46:11]

Reads a little weird, I think it'd be better to delete the job prior to |job|.

[Ryan Hamilton, 2014/04/22 21:54:44]

What do you mean by "delete the job prior to job"?

[Ryan Hamilton, 2014/04/22 21:57:45]

Oh, I see. Done.

+  void MarkOtherJobComplete(const Job& job);
+
  private:
   enum State {
     STATE_START,
@@ -133,6 +136,13 @@ class HttpStreamFactoryImpl::Job {
     STATE_NONE
   };
 
+  enum JobStatus {
+    STATUS_RUNNING,
+    STATUS_FAILED,
+    STATUS_BROKEN,
+    STATUS_SUCCEEDED
+  };
+
   void OnStreamReadyCallback();
   void OnWebSocketHandshakeStreamReadyCallback();
   // This callback function is called when a new SPDY session is created.
@@ -222,6 +232,8 @@ class HttpStreamFactoryImpl::Job {
 
   bool IsRequestEligibleForPipelining();
 
+  void MaybeMarkAlternateProtocolBroken();
+
   // Record histograms of latency until Connect() completes.
   static void LogHttpConnectedMetrics(const ClientSocketHandle& handle);
 
@@ -331,6 +343,9 @@ class HttpStreamFactoryImpl::Job {
   // True if an existing pipeline can handle this job's request.
   bool existing_available_pipeline_;
 
+  JobStatus job_status_;

[willchan no longer on Chromium, 2014/04/22 22:23:54]

At some point I think we need to remove the Alternate-Protocol logic from the
job and move it over to the HttpStreamFactoryImpl or the Request. I kinda feel
like a Job should not have to know that it's the "alternate". It should just run
to completion, and then notify some other object that it is done.

I'm still kicking around ideas in my head, but here are some things that come to
mind:
* Move the knowledge of the "alternate" to the Request or Factory
* Switch the Job to being an interface with a JobImpl as the base
implementation. Compose this base implementation with some other object that
understands the Alternate-Protocol relationship.

+  JobStatus other_job_status_;
+
   base::WeakPtrFactory<Job> ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Job);