Issue 2456613003: Merge M55: "Don't background pause suspend until we have future data."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2456613003: Merge M55: "Don't background pause suspend until we have future data." (Closed)

Created:
4 years, 1 month ago by DaleCurtis

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge M55: "Don't background pause suspend until we have future data." Otherwise the pause state is not reliable and we may incorrectly prevent background playback attempts. We can't always force background pause suspend since background playback may trigger a play() but we don't know the correct paused state yet. BUG=658680 TEST=new test. Review-Url: https://codereview.chromium.org/2449873006 Cr-Commit-Position: refs/heads/master@{#427910} (cherry picked from commit cc8baf72a3cfc63b1bd39710b8999b04508e43c8)

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	media/blink/webmediaplayer_impl.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
	M	media/blink/webmediaplayer_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

4 years, 1 month ago (2016-10-27 18:13:04 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
fc996babbcfe18b89db9355d0f5bd4d9d3c206ec.

Expand Messages | Collapse Messages