Remove BluetoothDevice.uuids attribute from WebBluetooth

Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

It was marked Deprecated for a brief time, but because
Web Bluetooth is moving out of experimental / origin trial
and shipping we will make the clean break without
maintaining the deprecated API in the shipped state.

BUG=653317
Committed: https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d
Cr-Commit-Position: refs/heads/master@{#427929}

[juncai, 2016-10-26 19:48:37]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[juncai, 2016-10-26 19:49:17]

Description was changed from

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth API

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

BUG=653317
==========

to

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

BUG=653317
==========

[commit-bot: I haz the power, 2016-10-26 19:49:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:58:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[juncai, 2016-10-26 21:22:04]

juncai@chromium.org changed reviewers:
+ rbyers@chromium.org, scheib@chromium.org

[juncai, 2016-10-26 21:22:05]

rbyers@chromium.org: Please review changes in 
//third_party/WebKit

scheib@chromium.org: Please review changes in 
//content/browser/bluetooth/web_bluetooth_service_impl.cc
//content/renderer/bluetooth/web_bluetooth_impl.cc
//third_party/WebKit/Source/modules/bluetooth
//third_party/WebKit/public/platform/modules/bluetooth

[juncai, 2016-10-26 21:24:24]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-10-26 21:28:19]

LGTM

[scheib, 2016-10-26 21:29:47]

Description was changed from

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

BUG=653317
==========

to

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

It was marked Deprecated for a brief time, but because
Web Bluetooth is moving out of experimental / origin trial
and shipping we will make the clean break without 
maintaining the deprecated API in the shipped state.

BUG=653317
==========

[Rick Byers, 2016-10-26 22:26:03]

LGTM

Who is doing the outreach to the developers signed up for the origin trial?

[juncai, 2016-10-26 22:33:52]

I think fbeaufort@ was reaching out to developers who signed up for the origin
trials for WebBluetooth API.

[ortuno, 2016-10-26 22:35:55]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-10-26 22:35:56]

https://codereview.chromium.org/2456613002/diff/1/content/browser/bluetooth/w...
File content/browser/bluetooth/web_bluetooth_service_impl.cc (right):

https://codereview.chromium.org/2456613002/diff/1/content/browser/bluetooth/w...
content/browser/bluetooth/web_bluetooth_service_impl.cc:787:
mojo::Array<mojo::String> filtered_uuids;
Also remove this.

[juncai, 2016-10-26 22:41:58]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 22:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-26 22:42:32]

https://codereview.chromium.org/2456613002/diff/1/content/browser/bluetooth/w...
File content/browser/bluetooth/web_bluetooth_service_impl.cc (right):

https://codereview.chromium.org/2456613002/diff/1/content/browser/bluetooth/w...
content/browser/bluetooth/web_bluetooth_service_impl.cc:787:
mojo::Array<mojo::String> filtered_uuids;
On 2016/10/26 22:35:55, ortuno wrote:
> Also remove this.

Thanks! Done.

[ortuno, 2016-10-26 22:44:56]

https://codereview.chromium.org/2456613002/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/web_bluetooth_service_impl.cc (right):

https://codereview.chromium.org/2456613002/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/web_bluetooth_service_impl.cc:787: for (const
BluetoothUUID& uuid : device->GetUUIDs()) {
Sorry I should have been clearer. GetUUIDs() is very unreliable now so there is
no point on iterating over it to log this information. Remove the for loop as
well.

[juncai, 2016-10-26 23:07:55]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 23:08:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:34:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:34:20]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-10-27 00:48:05]

https://codereview.chromium.org/2456613002/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/web_bluetooth_service_impl.cc (right):

https://codereview.chromium.org/2456613002/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/web_bluetooth_service_impl.cc:787: for (const
BluetoothUUID& uuid : device->GetUUIDs()) {
On 2016/10/26 22:44:56, ortuno wrote:
> Sorry I should have been clearer. GetUUIDs() is very unreliable now so there
is
> no point on iterating over it to log this information. Remove the for loop as
> well.

Done.

[juncai, 2016-10-27 00:48:31]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-10-27 00:48:32]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2456613002/#ps40001
(title: "address more comments")

[commit-bot: I haz the power, 2016-10-27 00:48:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:59:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[juncai, 2016-10-27 01:10:03]

juncai@chromium.org changed reviewers:
+ dcheng@chromium.org

[juncai, 2016-10-27 01:10:03]

dcheng@chromium.org: Please review changes in
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

[dcheng, 2016-10-27 03:05:20]

mojo lgtm

[juncai, 2016-10-27 03:39:57]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-10-27 03:40:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 03:45:57]

Description was changed from

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

It was marked Deprecated for a brief time, but because
Web Bluetooth is moving out of experimental / origin trial
and shipping we will make the clean break without 
maintaining the deprecated API in the shipped state.

BUG=653317
==========

to

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

It was marked Deprecated for a brief time, but because
Web Bluetooth is moving out of experimental / origin trial
and shipping we will make the clean break without 
maintaining the deprecated API in the shipped state.

BUG=653317
==========

[commit-bot: I haz the power, 2016-10-27 03:45:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-27 03:47:45]

Description was changed from

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

It was marked Deprecated for a brief time, but because
Web Bluetooth is moving out of experimental / origin trial
and shipping we will make the clean break without 
maintaining the deprecated API in the shipped state.

BUG=653317
==========

to

==========
Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

It was marked Deprecated for a brief time, but because
Web Bluetooth is moving out of experimental / origin trial
and shipping we will make the clean break without
maintaining the deprecated API in the shipped state.

BUG=653317

Committed: https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d
Cr-Commit-Position: refs/heads/master@{#427929}
==========

[commit-bot: I haz the power, 2016-10-27 03:47:46]

Patchset 3 (id:??) landed as
https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d
Cr-Commit-Position: refs/heads/master@{#427929}