Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 24566004: Add an API for additional profile log records (Closed)

Created:
7 years, 2 months ago by Søren Thygesen Gjesse
Modified:
5 years ago
CC:
v8-dev
Visibility:
Public.

Description

Add an API for additional profile log records Add the API V8::AddProfilerMark which will add a "mark" record into the profile log (if any). Currently the mark record is only added when using the log-based profiler. This allows the embedder to add marks to the profile to indicate specific points in the execution when profiling. Update the profile processer to display the marks and the number of ticks which happened before each mark. Also added calculation of the bytes of generated machine code which is displayed with the marks and as a general statistics. Also updated to profile processer to display the number of ticks for each VM state and not just GC. R=jkummerow@chromium.org

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -29 lines) Patch
M include/v8.h View 1 chunk +5 lines, -0 lines 1 comment Download
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/log.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.default View 2 chunks +10 lines, -3 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.func-info View 2 chunks +11 lines, -3 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.gc-state View 2 chunks +5 lines, -3 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.ignore-unknown View 2 chunks +10 lines, -3 lines 1 comment Download
M test/mjsunit/tools/tickprocessor-test.separate-ic View 2 chunks +10 lines, -3 lines 0 comments Download
M tools/profile.js View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/tickprocessor.js View 14 chunks +100 lines, -14 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Søren Gjesse
7 years, 2 months ago (2013-09-25 13:26:20 UTC) #1
yurys
lgtm https://codereview.chromium.org/24566004/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/24566004/diff/1/include/v8.h#newcode4605 include/v8.h:4605: */ v8::CpuProfiler may be a better place for ...
7 years, 2 months ago (2013-09-27 09:31:37 UTC) #2
Yang
7 years, 2 months ago (2013-09-30 11:25:02 UTC) #3
I agree with Yury, CpuProfiler in v8-profiler.h is a better place for this.

https://codereview.chromium.org/24566004/diff/1/test/mjsunit/tools/tickproces...
File test/mjsunit/tools/tickprocessor-test.ignore-unknown (right):

https://codereview.chromium.org/24566004/diff/1/test/mjsunit/tools/tickproces...
test/mjsunit/tools/tickprocessor-test.ignore-unknown:21: JavaScript             
13      118.2%
118%... sounds like a bug somewhere...

https://codereview.chromium.org/24566004/diff/1/tools/tickprocessor.js
File tools/tickprocessor.js (right):

https://codereview.chromium.org/24566004/diff/1/tools/tickprocessor.js#newcod...
tools/tickprocessor.js:546: ' ' + padLeft('Ticks', 6) +
Please align those lines like the print below.

Powered by Google App Engine
This is Rietveld 408576698