Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: sandbox/win/src/sandbox.h

Issue 2456573002: Revert "Fix sandbox::PolicyBase leak" (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/policy_target_test.cc ('k') | sandbox/win/tests/common/controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/sandbox.h
diff --git a/sandbox/win/src/sandbox.h b/sandbox/win/src/sandbox.h
index 0f613f7d681870d2f1407fd267c42a3cbbf652fd..029868d4a7f948f9e94ace8b7d48319b85526635 100644
--- a/sandbox/win/src/sandbox.h
+++ b/sandbox/win/src/sandbox.h
@@ -21,7 +21,6 @@
#include <windows.h>
-#include "base/memory/ref_counted.h"
#include "sandbox/win/src/sandbox_policy.h"
#include "sandbox/win/src/sandbox_types.h"
@@ -57,7 +56,7 @@ class BrokerServices {
// Returns the interface pointer to a new, empty policy object. Use this
// interface to specify the sandbox policy for new processes created by
// SpawnTarget()
- virtual scoped_refptr<TargetPolicy> CreatePolicy() = 0;
+ virtual TargetPolicy* CreatePolicy() = 0;
// Creates a new target (child process) in a suspended state.
// Parameters:
@@ -80,7 +79,7 @@ class BrokerServices {
// ALL_OK if successful. All other return values imply failure.
virtual ResultCode SpawnTarget(const wchar_t* exe_path,
const wchar_t* command_line,
- scoped_refptr<TargetPolicy> policy,
+ TargetPolicy* policy,
ResultCode* last_warning,
DWORD* last_error,
PROCESS_INFORMATION* target) = 0;
« no previous file with comments | « sandbox/win/src/policy_target_test.cc ('k') | sandbox/win/tests/common/controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698