Remove supports_touch_events flag from BasicDesktopEnvironment

Remove supports_touch_events flag from BasicDesktopEnvironment

supports_touch_events flag was always enabled on platforms that support
it, so it's not necessary to put it in BasicDesktopEnvironment.

Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
Committed: https://crrev.com/b3e637eba149cbfc8506c1accf8b3820af348f1a
Cr-Original-Commit-Position: refs/heads/master@{#427858}
Cr-Commit-Position: refs/heads/master@{#428211}

[Sergey Ulanov, 2016-10-26 18:52:01]

sergeyu@chromium.org changed reviewers:
+ zijiehe@chromium.org

[Hzj_jie, 2016-10-26 18:56:32]

lgtm with nits.

https://codereview.chromium.org/2456563002/diff/1/remoting/host/desktop_sessi...
File remoting/host/desktop_session_proxy.cc (right):

https://codereview.chromium.org/2456563002/diff/1/remoting/host/desktop_sessi...
remoting/host/desktop_session_proxy.cc:143: result +=
protocol::kSendInitialResolution;
string::append?

https://codereview.chromium.org/2456563002/diff/1/remoting/host/me2me_desktop...
File remoting/host/me2me_desktop_environment.cc (right):

https://codereview.chromium.org/2456563002/diff/1/remoting/host/me2me_desktop...
remoting/host/me2me_desktop_environment.cc:57: capabilities +=
protocol::kTouchEventsCapability;
string::append?

[Sergey Ulanov, 2016-10-26 19:32:56]

https://codereview.chromium.org/2456563002/diff/1/remoting/host/desktop_sessi...
File remoting/host/desktop_session_proxy.cc (right):

https://codereview.chromium.org/2456563002/diff/1/remoting/host/desktop_sessi...
remoting/host/desktop_session_proxy.cc:143: result +=
protocol::kSendInitialResolution;
On 2016/10/26 18:56:32, Hzj_jie wrote:
> string::append?

+= is more readable and does the same thing

https://codereview.chromium.org/2456563002/diff/1/remoting/host/me2me_desktop...
File remoting/host/me2me_desktop_environment.cc (right):

https://codereview.chromium.org/2456563002/diff/1/remoting/host/me2me_desktop...
remoting/host/me2me_desktop_environment.cc:57: capabilities +=
protocol::kTouchEventsCapability;
On 2016/10/26 18:56:32, Hzj_jie wrote:
> string::append?

same here. I think += is more readable.

[Sergey Ulanov, 2016-10-26 19:33:04]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:34:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:44:36]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Ulanov, 2016-10-26 22:11:03]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-10-26 22:11:03]

The patchset sent to the CQ was uploaded after l-g-t-m from zijiehe@chromium.org
Link to the patchset: https://codereview.chromium.org/2456563002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-10-26 22:11:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2016-10-26 22:38:39]

https://codereview.chromium.org/2456563002/diff/1/remoting/host/desktop_sessi...
File remoting/host/desktop_session_proxy.cc (right):

https://codereview.chromium.org/2456563002/diff/1/remoting/host/desktop_sessi...
remoting/host/desktop_session_proxy.cc:143: result +=
protocol::kSendInitialResolution;
On 2016/10/26 19:32:56, Sergey Ulanov wrote:
> On 2016/10/26 18:56:32, Hzj_jie wrote:
> > string::append?
> 
> += is more readable and does the same thing

No matter, it's more like a personal preference as
result.append("a").append("b"), instead of (result += "a") += "b".

[commit-bot: I haz the power, 2016-10-26 22:46:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 22:50:52]

Description was changed from

==========
Remove supports_touch_events flag from BasicDesktopEnvironment

supports_touch_events flag was always enabled on platforms that support
it, so it's not necessary to put it in BasicDesktopEnvironment.
==========

to

==========
Remove supports_touch_events flag from BasicDesktopEnvironment

supports_touch_events flag was always enabled on platforms that support
it, so it's not necessary to put it in BasicDesktopEnvironment.

Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
Cr-Commit-Position: refs/heads/master@{#427858}
==========

[commit-bot: I haz the power, 2016-10-26 22:50:53]

Patchset 2 (id:??) landed as
https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
Cr-Commit-Position: refs/heads/master@{#427858}

[foolip, 2016-10-27 08:38:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2458513004/ by foolip@chromium.org.

The reason for reverting is: IpcDesktopEnvironmentTest.CapabilitiesNoTouch
failing on Win10 Tests x64

BUG=659927.

[Sergey Ulanov, 2016-10-27 18:10:18]

Description was changed from

==========
Remove supports_touch_events flag from BasicDesktopEnvironment

supports_touch_events flag was always enabled on platforms that support
it, so it's not necessary to put it in BasicDesktopEnvironment.

Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
Cr-Commit-Position: refs/heads/master@{#427858}
==========

to

==========
Remove supports_touch_events flag from BasicDesktopEnvironment

supports_touch_events flag was always enabled on platforms that support
it, so it's not necessary to put it in BasicDesktopEnvironment.

Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
Cr-Commit-Position: refs/heads/master@{#427858}
==========

[Sergey Ulanov, 2016-10-27 21:41:57]

Patchset #3 (id:40001) has been deleted

[Sergey Ulanov, 2016-10-27 21:42:02]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-10-27 21:42:02]

The patchset sent to the CQ was uploaded after l-g-t-m from zijiehe@chromium.org
Link to the patchset: https://codereview.chromium.org/2456563002/#ps60001
(title: "remove test")

[commit-bot: I haz the power, 2016-10-27 21:42:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:36:05]

Description was changed from

==========
Remove supports_touch_events flag from BasicDesktopEnvironment

supports_touch_events flag was always enabled on platforms that support
it, so it's not necessary to put it in BasicDesktopEnvironment.

Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
Cr-Commit-Position: refs/heads/master@{#427858}
==========

to

==========
Remove supports_touch_events flag from BasicDesktopEnvironment

supports_touch_events flag was always enabled on platforms that support
it, so it's not necessary to put it in BasicDesktopEnvironment.

Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
Committed: https://crrev.com/b3e637eba149cbfc8506c1accf8b3820af348f1a
Cr-Original-Commit-Position: refs/heads/master@{#427858}
Cr-Commit-Position: refs/heads/master@{#428211}
==========

[commit-bot: I haz the power, 2016-10-27 23:36:06]

Patchset 3 (id:??) landed as
https://crrev.com/b3e637eba149cbfc8506c1accf8b3820af348f1a
Cr-Commit-Position: refs/heads/master@{#428211}