Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2456523004: sync compositor: Implement post metadata to UI (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, jam, darin-cc_chromium.org, Tobias Sargeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compositor: Implement post metadata to UI For the async draw path. The frame is signaled on the IO thread, but the metadata still needs to be posted back to the UI thread. Host registers itself with Filter on UI thread, so Filter can keep a routing_id to Host map. Note that Host and Filter lifetimes are still independent. With this CL, the async path is feature complete. BUG=636164 Committed: https://crrev.com/524d4c0b9df4f2df8da612826a4bf539d4d839b1 Cr-Commit-Position: refs/heads/master@{#428277}

Patch Set 1 #

Patch Set 2 : check registered #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -13 lines) Patch
M content/browser/android/synchronous_compositor_browser_filter.h View 4 chunks +11 lines, -0 lines 0 comments Download
M content/browser/android/synchronous_compositor_browser_filter.cc View 1 2 2 chunks +37 lines, -1 line 0 comments Download
M content/browser/android/synchronous_compositor_host.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 1 2 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
boliu
4 years, 1 month ago (2016-10-26 22:40:40 UTC) #2
boliu
err, I mean.. ptal :p
4 years, 1 month ago (2016-10-26 22:40:52 UTC) #3
sgurun-gerrit only
https://codereview.chromium.org/2456523004/diff/20001/content/browser/android/synchronous_compositor_host.h File content/browser/android/synchronous_compositor_host.h (right): https://codereview.chromium.org/2456523004/diff/20001/content/browser/android/synchronous_compositor_host.h#newcode109 content/browser/android/synchronous_compositor_host.h:109: bool registered_with_filter_ = false; I don't know if such ...
4 years, 1 month ago (2016-10-27 23:14:48 UTC) #6
sgurun-gerrit only
On 2016/10/27 23:14:48, sgurun wrote: > https://codereview.chromium.org/2456523004/diff/20001/content/browser/android/synchronous_compositor_host.h > File content/browser/android/synchronous_compositor_host.h (right): > > https://codereview.chromium.org/2456523004/diff/20001/content/browser/android/synchronous_compositor_host.h#newcode109 > ...
4 years, 1 month ago (2016-10-27 23:15:01 UTC) #7
boliu
https://codereview.chromium.org/2456523004/diff/20001/content/browser/android/synchronous_compositor_host.h File content/browser/android/synchronous_compositor_host.h (right): https://codereview.chromium.org/2456523004/diff/20001/content/browser/android/synchronous_compositor_host.h#newcode109 content/browser/android/synchronous_compositor_host.h:109: bool registered_with_filter_ = false; On 2016/10/27 23:14:48, sgurun wrote: ...
4 years, 1 month ago (2016-10-28 00:41:38 UTC) #8
boliu
had to rebase on top of https://codereview.chromium.org/2458743002/
4 years, 1 month ago (2016-10-28 01:10:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456523004/40001
4 years, 1 month ago (2016-10-28 01:10:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/169743)
4 years, 1 month ago (2016-10-28 02:36:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456523004/40001
4 years, 1 month ago (2016-10-28 02:42:36 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 04:04:33 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 04:06:47 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/524d4c0b9df4f2df8da612826a4bf539d4d839b1
Cr-Commit-Position: refs/heads/master@{#428277}

Powered by Google App Engine
This is Rietveld 408576698