Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: net/cert/ev_root_ca_metadata.h

Issue 2456523003: Mac EV verification using Chrome methods rather than OS methods. (Closed)
Patch Set: fix weak keys test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ev_root_ca_metadata.h
diff --git a/net/cert/ev_root_ca_metadata.h b/net/cert/ev_root_ca_metadata.h
index dfb14bc6aa4290eb9a7d711c0f02fb5f9ee7fb6f..630270257e5fabd39942b4775bade0adfbe983af 100644
--- a/net/cert/ev_root_ca_metadata.h
+++ b/net/cert/ev_root_ca_metadata.h
@@ -27,6 +27,10 @@ struct DefaultLazyInstanceTraits;
namespace net {
+namespace der {
+class Input;
+}
Ryan Sleevi 2016/11/08 00:11:21 nit: } // namespace der (see line 26)
mattm 2016/11/08 23:06:25 Done.
+
// A singleton. This class stores the meta data of the root CAs that issue
// extended-validation (EV) certificates.
class NET_EXPORT_PRIVATE EVRootCAMetadata {
@@ -35,11 +39,14 @@ class NET_EXPORT_PRIVATE EVRootCAMetadata {
typedef SECOidTag PolicyOID;
#elif defined(OS_WIN)
typedef const char* PolicyOID;
+#elif defined(OS_MACOSX)
+ // DER-encoded OID value (no tag or length).
+ typedef der::Input PolicyOID;
#endif
static EVRootCAMetadata* GetInstance();
-#if defined(USE_NSS_CERTS) || defined(OS_WIN)
+#if defined(USE_NSS_CERTS) || defined(OS_WIN) || defined(OS_MACOSX)
// Returns true if policy_oid is an EV policy OID of some root CA.
bool IsEVPolicyOID(PolicyOID policy_oid) const;
@@ -80,6 +87,12 @@ class NET_EXPORT_PRIVATE EVRootCAMetadata {
// extra_cas_ contains any EV CA metadata that was added at runtime.
ExtraEVCAMap extra_cas_;
+#elif defined(OS_MACOSX)
+ typedef std::map<SHA1HashValue, std::string, SHA1HashValueLessThan>
+ ExtraEVCAMap;
+
+ // extra_cas_ contains any EV CA metadata that was added at runtime.
+ ExtraEVCAMap extra_cas_;
#endif
DISALLOW_COPY_AND_ASSIGN(EVRootCAMetadata);

Powered by Google App Engine
This is Rietveld 408576698