Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2456503002: Ntp: add test for setSearchProviderHasLogo using old ui. (Closed)

Created:
4 years, 1 month ago by Michael van Ouwerkerk
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: add test for setSearchProviderHasLogo using old ui. * Add testSetSearchProviderHasLogo, this is our only test for the old (non-snippets) ui * Move private helpers to bottom of file * Move setUp, tearDown, and startMainActivity to top of file BUG=659631 Committed: https://crrev.com/2f9c3eb5b0abb57af96273082500434ba9f23626 Cr-Commit-Position: refs/heads/master@{#427679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -83 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java View 4 chunks +95 lines, -83 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 1 month ago (2016-10-26 12:55:34 UTC) #5
Bernhard Bauer
lgtm
4 years, 1 month ago (2016-10-26 13:36:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456503002/1
4 years, 1 month ago (2016-10-26 13:50:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 13:55:07 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 13:57:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f9c3eb5b0abb57af96273082500434ba9f23626
Cr-Commit-Position: refs/heads/master@{#427679}

Powered by Google App Engine
This is Rietveld 408576698