Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 24565004: Split swarm_triggered into 3 builders to make it easier on devs. (Closed)

Created:
7 years, 2 months ago by M-A Ruel
Modified:
7 years, 2 months ago
CC:
agable, chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org, csharp, Vadim Sh.
Base URL:
https://chromium.googlesource.com/a/chromium/tools/build.git@master
Visibility:
Public.

Description

Split swarm_triggered into 3 builders to make it easier on devs. Stop hardcoding swarm_triggered. The 3 builders do the exact same thing, but it is easier for devs to know where the test run. R=xusydoc@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=229414

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve docstring #

Patch Set 3 : do not remove swarm_triggered yet. #

Patch Set 4 : do not remove swarm_triggered yet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 1 2 7 chunks +33 lines, -6 lines 0 comments Download
M masters/master.tryserver.chromium/slaves.cfg View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M scripts/master/factory/chromium_commands.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/master/factory/swarm_factory.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
It also have https://codereview.chromium.org/24633002 that is the CQ part, the CQ will have to have ...
7 years, 2 months ago (2013-09-25 18:28:38 UTC) #1
Mike Stip (use stip instead)
lgtm https://chromiumcodereview.appspot.com/24565004/diff/1/scripts/master/factory/swarm_factory.py File scripts/master/factory/swarm_factory.py (right): https://chromiumcodereview.appspot.com/24565004/diff/1/scripts/master/factory/swarm_factory.py#newcode13 scripts/master/factory/swarm_factory.py:13: - One SwarmTestBuilder() builder named something like 'swarm_triggered'. ...
7 years, 2 months ago (2013-09-26 01:03:05 UTC) #2
M-A Ruel
+today's trooper I changed the CL to not delete swarm_triggered, so the transition will be ...
7 years, 2 months ago (2013-10-18 14:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/24565004/107001
7 years, 2 months ago (2013-10-18 14:38:14 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-18 14:39:20 UTC) #5
Message was sent while issue was closed.
Change committed as 229414

Powered by Google App Engine
This is Rietveld 408576698