third_party/WebKit/Source/core/frame/csp/CSPSource.h - Issue 2456493002: Splitting *Matches functions in CSPSource

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/frame/csp/CSPSource.h

Issue 2456493002: Splitting *Matches functions in CSPSource (Closed)

Patch Set: Removing equalIgnoringCase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CSPSource_h	5 #ifndef CSPSource_h

6 #define CSPSource_h	6 #define CSPSource_h

7	7

8 #include "core/CoreExport.h"	8 #include "core/CoreExport.h"

9 #include "core/frame/csp/ContentSecurityPolicy.h"	9 #include "core/frame/csp/ContentSecurityPolicy.h"

10 #include "platform/heap/Handle.h"	10 #include "platform/heap/Handle.h"

(...skipping 23 matching lines...) Expand all Loading...
34	34

35 DECLARE_TRACE();	35 DECLARE_TRACE();

36	36

37 private:	37 private:

38 bool schemeMatches(const KURL&) const;	38 bool schemeMatches(const KURL&) const;

39 bool hostMatches(const KURL&) const;	39 bool hostMatches(const KURL&) const;

40 bool pathMatches(const KURL&) const;	40 bool pathMatches(const KURL&) const;

41 bool portMatches(const KURL&) const;	41 bool portMatches(const KURL&) const;

42 bool isSchemeOnly() const;	42 bool isSchemeOnly() const;

43	43

	44 bool schemeMatches(const String&) const;

	45 bool hostMatches(const String&) const;

	46 bool pathMatches(const String&) const;

	47 bool portMatches(int, const String&) const;
	Mike West 2016/10/26 12:25:16 I think we can actually just remove the KURL varia I think we can actually just remove the KURL variants here; they're only called from `matches()`, and you can just update that callsite to pass in the relevant bits of the URL.
	48

44 Member<ContentSecurityPolicy> m_policy;	49 Member<ContentSecurityPolicy> m_policy;

45 String m_scheme;	50 String m_scheme;

46 String m_host;	51 String m_host;

47 int m_port;	52 int m_port;

48 String m_path;	53 String m_path;

49	54

50 WildcardDisposition m_hostWildcard;	55 WildcardDisposition m_hostWildcard;

51 WildcardDisposition m_portWildcard;	56 WildcardDisposition m_portWildcard;

52 };	57 };

53	58

54 } // namespace blink	59 } // namespace blink

55	60

56 #endif	61 #endif

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/csp/CSPSource.cpp » ('j') | third_party/WebKit/Source/core/frame/csp/CSPSource.cpp » ('J')